Re: [RFC PATCH 6/6] selftests/vfio: Enable VFIO selftests on ppc64 and ppc64le

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The VFIO selftests will still be silently skipped on PowerPC when building from the top-level kernel directory (e.g., via `make kselftest`).
--

commit e8d7fbeb96b4d48f400e3fc2cba19a75370e70e6
Author: Narayana Murty N <nnmlinux@linux.ibm.com>

selftests/vfio: Enable VFIO selftests on ppc64 and ppc64le

This commit modifies the VFIO selftests Makefile to enable building on
PowerPC architectures. It allows PowerPC systems to run DMA mapping
tests against the legacy VFIO container backend.

> diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> index e6e8cb52ab030..dc686a38ab0a9 100644
> --- a/tools/testing/selftests/vfio/Makefile
> +++ b/tools/testing/selftests/vfio/Makefile
> @@ -1,6 +1,6 @@
>  ARCH ?= $(shell uname -m)
>  
> -ifeq (,$(filter $(ARCH),aarch64 arm64 x86 x86_64))
> +ifeq (,$(filter $(ARCH),aarch64 arm64 x86 x86_64 ppc64 ppc64le))

[Severity: Medium]
Will this filter correctly match the architecture when building via the
top-level make kselftest?

The top-level kernel build system evaluates SUBARCH using
scripts/subarch.include, which maps both ppc64 and ppc64le to the canonical
name powerpc, exporting ARCH=powerpc to sub-makes.

Because powerpc is not included in this filter list, the tests will still
be silently skipped during automated testing when invoked from the
top-level kernel directory.

>  # Do nothing on unsupported architectures
>  include ../lib.mk
>  else

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703032806.40946-1-nnmlinux@linux.ibm.com?part=6