From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63F4A3B42EC for ; Wed, 8 Jul 2026 18:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783535131; cv=none; b=nttJNZqkTnvSuR4HV76tO7LZZfxO0CJgrXRYEmdiLOH86Zq2SVtpTQCTCgjosCFqjBnn8gGXY5RBAuDFhVFzjhr1oLxg8GWxVreUjAeAxPhyiri0Y/L7lGvqj+0yBiGsn+Wgzxy0ycrhorK8qxIu1AQ55sP+wigvDUkR0xksOzk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783535131; c=relaxed/simple; bh=4l0mFBJOiD9VR6tHQIXH8PsiJlQlx/e0iU2aPRxHgKk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fQz8jZW+Rs70EM2yKlZeKWNjrp7NblpsHSsvO4jUqkLL2cIvot37J6WQ38N2dWuW8+2r7yLrmMTiuS79E7Dk8PGcdeSirB5tdXww7tP5eYK1hgHtOImyWguoFinQBqNfNCDCaB3m1HZ9W+NHOB2byE7S0LChqF+jQNWLXeICOvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vmqaze14; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vmqaze14" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783535127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PfxyrrfIwD9kYVMYsO/FmdMfv3qC4C0W8ePlEH24TgQ=; b=vmqaze14nUHeSei984OmS4zP04jAF2jhD1DzpbX5YMZZaGciJFkLcjbYApZ2gXcUUUkq3Q uEeIZIRYHmObb5EAhHjzTApNbRhhLTHUnDTPB6Iaq4lsO8DQ067RXuwQJC38eOo4skX3Sj lwbr09z4D7u3ZRPJz6xMhHMzkzz0dks= From: Fuad Tabba To: kvm@vger.kernel.org Cc: kvmarm@lists.linux.dev, Will Deacon , Alexandru Elisei , Suzuki K Poulose , Andre Przywara , Oliver Upton , Marc Zyngier , Fuad Tabba Subject: [PATCH kvmtool v2 2/4] Remove newline from end of die() aborts Date: Wed, 8 Jul 2026 19:25:08 +0100 Message-Id: <20260708182510.2181857-3-fuad.tabba@linux.dev> In-Reply-To: <20260708182510.2181857-1-fuad.tabba@linux.dev> References: <20260708182510.2181857-1-fuad.tabba@linux.dev> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT die() already adds the newline at the end of the string. Reviewed-by: Suzuki K Poulose Signed-off-by: Fuad Tabba --- util/util.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/util/util.c b/util/util.c index 6f41e2c..05d49c4 100644 --- a/util/util.c +++ b/util/util.c @@ -128,14 +128,14 @@ void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size) unsigned long blk_size; if (statfs(htlbfs_path, &sfs) < 0) - die("Can't stat %s\n", htlbfs_path); + die("Can't stat %s", htlbfs_path); if ((unsigned int)sfs.f_type != HUGETLBFS_MAGIC) - die("%s is not hugetlbfs!\n", htlbfs_path); + die("%s is not hugetlbfs!", htlbfs_path); blk_size = (unsigned long)sfs.f_bsize; if (sfs.f_bsize == 0 || blk_size > size) { - die("Can't use hugetlbfs pagesize %ld for mem size %lld\n", + die("Can't use hugetlbfs pagesize %ld for mem size %lld", blk_size, (unsigned long long)size); } @@ -144,10 +144,10 @@ void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size) snprintf(mpath, PATH_MAX, "%s/kvmtoolXXXXXX", htlbfs_path); fd = mkstemp(mpath); if (fd < 0) - die("Can't open %s for hugetlbfs map\n", mpath); + die("Can't open %s for hugetlbfs map", mpath); unlink(mpath); if (ftruncate(fd, size) < 0) - die("Can't ftruncate for mem mapping size %lld\n", + die("Can't ftruncate for mem mapping size %lld", (unsigned long long)size); addr = mmap(NULL, size, PROT_RW, MAP_PRIVATE, fd, 0); close(fd); -- 2.39.5