Re: [PATCH v1 1/2] KVM: selftests: SEV: Verify unsupported VM types are rejected at creation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unreachable file descriptor cleanup logic due to `TEST_ASSERT` abortion behavior.
--

--- Patch [1]: [PATCH v1 1/2] KVM: selftests: SEV: Verify unsupported VM types are rejected at creation ---
commit 6d2bb062d11a83854e4168e36bd8f632c92e6ba6
Author: Hemanth Selam <hemanth.selam@gmail.com>

KVM: selftests: SEV: Verify unsupported VM types are rejected at creation

This commit adds a new test to verify that unsupported SEV VM types are
rejected by KVM_CREATE_VM. It introduces a helper function to test invalid
types and asserts that the creation fails with -EINVAL.

> diff --git a/tools/testing/selftests/kvm/x86/sev_init2_tests.c b/tools/testing/selftests/kvm/x86/sev_init2_tests.c
> index 8db88c355f165..724ff11f16c94 100644
> --- a/tools/testing/selftests/kvm/x86/sev_init2_tests.c
> +++ b/tools/testing/selftests/kvm/x86/sev_init2_tests.c
[ ... ]
> @@ -73,19 +74,34 @@ static void test_init2_invalid(unsigned long vm_type, struct kvm_sev_init *init,
>  	kvm_vm_free(vm);
>  }
>  
> +static void test_create_invalid_type(unsigned long vm_type, const char *msg)
> +{
> +	int fd = __kvm_ioctl(kvm_fd, KVM_CREATE_VM, (void *)vm_type);
> +
> +	TEST_ASSERT(fd < 0 && errno == EINVAL,
> +		    "KVM_CREATE_VM should reject unsupported type (%s), got fd=%d errno=%d",
> +		    msg, fd, errno);
> +	if (fd >= 0)
> +		close(fd);

[Severity: Low]
Since TEST_ASSERT() will unconditionally abort the test program if the
condition fails (which happens if fd >= 0), is this close() block dead code?

If the assert passes, fd is strictly less than 0, making the condition
false. If the assert fails, the program terminates before reaching the
close() statement.

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709164751.621326-1-hemanth.selam@gmail.com?part=1