Re: [PATCH v7 09/11] x86/virt/tdx: Enable Dynamic PAMT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The global variable `tdx_enable_dpamt` is defined without the `static` keyword, polluting the global namespace.
--

--- Patch [9]: [PATCH v7 09/11] x86/virt/tdx: Enable Dynamic PAMT ---
commit a5e057035573a191a887572dacd25f3faa79112d
Author: Kiryl Shutsemau <kas@kernel.org>

x86/virt/tdx: Enable Dynamic PAMT

This commit enables Dynamic PAMT for TDX modules to reduce memory usage
during module initialization. It introduces a kernel command line parameter
"tdx_dpamt" to allow users to opt-in to this feature when supported by the
hardware.

> diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
> index e31b62f36300d..69834b0d3e602 100644
> --- a/arch/x86/virt/vmx/tdx/tdx.c
> +++ b/arch/x86/virt/vmx/tdx/tdx.c
> @@ -47,6 +47,8 @@
>  #include "seamcall_internal.h"
>  #include "tdx.h"
>  
> +bool tdx_enable_dpamt __ro_after_init;

[Severity: Low]
Since tdx_enable_dpamt is only used within this file, should it be marked
as static? Leaving it globally exposed can trigger compiler warnings like
-Wmissing-declarations when building with W=1 and unnecessarily pollutes
the global namespace.

> +
>  struct tdx_module_state {
>  	bool initialized;
>  	bool sysinit_done;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260718014500.2231262-1-rick.p.edgecombe@intel.com?part=9