Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: berrange@redhat.com, kchamart@redhat.com,
	pierrick.bouvier@oss.qualcomm.com, peter.maydell@linaro.org,
	mst@redhat.com, cohuck@redhat.com, pbonzini@redhat.com,
	eblake@redhat.com, armbru@redhat.com,
	lorenzo.pieralisi@linaro.org, gshan@redhat.com
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvm@vger.kernel.org
Subject: [RFC v2 08/24] target/arm/kvm: Use kvm_vm_check_extension() where necessary
Date: Tue, 28 Jul 2026 13:26:14 -0600	[thread overview]
Message-ID: <20260728192630.240375-9-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <20260728192630.240375-1-mathieu.poirier@linaro.org>

From: Jean-Philippe Brucker <jean-philippe@linaro.org>

The Arm KVM code can return different values from KVM_CHECK_EXTENSION
depending on the VM type. Use kvm_vm_check_extension() where necessary
to ensure we get the right response from KVM.

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 target/arm/kvm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index d86e66e056b9..ca25b707a0a8 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -331,7 +331,7 @@ static void kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
                              1 << KVM_ARM_VCPU_PTRAUTH_GENERIC);
     }
 
-    if (kvm_check_extension(kvm_state, KVM_CAP_ARM_PMU_V3)) {
+    if (kvm_vm_check_extension(kvm_state, KVM_CAP_ARM_PMU_V3)) {
         init.features[0] |= 1 << KVM_ARM_VCPU_PMU_V3;
         pmu_supported = true;
         features |= 1ULL << ARM_FEATURE_PMU;
@@ -636,7 +636,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
         return -EINVAL;
     }
 
-    if (kvm_check_extension(s, KVM_CAP_ARM_NISV_TO_USER)) {
+    if (kvm_vm_check_extension(s, KVM_CAP_ARM_NISV_TO_USER)) {
         if (kvm_vm_enable_cap(s, KVM_CAP_ARM_NISV_TO_USER, 0)) {
             error_report("Failed to enable KVM_CAP_ARM_NISV_TO_USER cap");
         } else {
@@ -667,11 +667,11 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
         }
     }
 
-    max_hw_wps = kvm_check_extension(s, KVM_CAP_GUEST_DEBUG_HW_WPS);
+    max_hw_wps = kvm_vm_check_extension(s, KVM_CAP_GUEST_DEBUG_HW_WPS);
     hw_watchpoints = g_array_sized_new(true, true,
                                        sizeof(HWWatchpoint), max_hw_wps);
 
-    max_hw_bps = kvm_check_extension(s, KVM_CAP_GUEST_DEBUG_HW_BPS);
+    max_hw_bps = kvm_vm_check_extension(s, KVM_CAP_GUEST_DEBUG_HW_BPS);
     hw_breakpoints = g_array_sized_new(true, true,
                                        sizeof(HWBreakpoint), max_hw_bps);
 
@@ -1913,7 +1913,7 @@ void kvm_arm_pvtime_init(ARMCPU *cpu, uint64_t ipa)
 
 void kvm_arm_steal_time_finalize(ARMCPU *cpu, Error **errp)
 {
-    bool has_steal_time = kvm_check_extension(kvm_state, KVM_CAP_STEAL_TIME);
+    bool has_steal_time = kvm_vm_check_extension(kvm_state, KVM_CAP_STEAL_TIME);
 
     if (cpu->kvm_steal_time == ON_OFF_AUTO_AUTO) {
         if (!has_steal_time || !arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) {
-- 
2.43.0


  parent reply	other threads:[~2026-07-28 19:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 19:26 [RFC v2 00/24] Add Realm support to QEMU-VMM Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 01/24] linux-headers: Add RME related definitions Mathieu Poirier
2026-07-30  5:41   ` Kohei Enju
2026-07-30  6:08     ` Gavin Shan
2026-07-30  6:13       ` Kohei Enju
2026-07-28 19:26 ` [RFC v2 02/24] target/arm/kvm: Return immediately on error in kvm_arch_init() Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 03/24] target/arm: Add confidential guest support Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 04/24] target/arm/kvm-rme: Add mechanic to initialize realms Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 05/24] target/arm/kvm: Split kvm_arch_get/put_registers Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 06/24] target/arm/kvm-rme: Initialize vCPU Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 07/24] target/arm/kvm: Create scratch Realm VM when requested Mathieu Poirier
2026-07-28 19:26 ` Mathieu Poirier [this message]
2026-07-28 19:26 ` [RFC v2 09/24] hw/core/loader: Add a ROM loader notifier Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 10/24] target/arm/kvm-rme: Keep track of images loaded in Realm memory Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 11/24] target/arm/kvm-rme: Populate Realm with runtime images Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 12/24] target/arm/cpu: Set number of breakpoints and watchpoints in KVM Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 13/24] target/arm/cpu: Set number of PMU counters " Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 14/24] target/arm/cpu: Don't read Realm registers Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 15/24] hw/arm/virt: Set proper conduit method for Realms Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 16/24] hw/arm/virt: Embed Realm VM type with IPA address space Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 17/24] hw/arm/virt: Reserve one bit of guest physical address for RME Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 18/24] hw/arm/virt: Disable DTB randomness for confidential VMs Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 19/24] hw/arm/virt: Move virt_flash_create() to machvirt_init() Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 20/24] hw/arm/virt: Use RAM instead of flash for confidential guest firmware Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 21/24] target/arm/kvm-rme: Add DMA remapping for the shared memory region Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 22/24] docs/interop/firmware.json: Add arm-rme firmware feature Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 23/24] hw/arm/boot: Load DTB as is for confidential VMs Mathieu Poirier
2026-07-28 19:26 ` [RFC v2 24/24] hw/arm/boot: Skip bootloader for confidential guests Mathieu Poirier
2026-07-30  5:11 ` [RFC v2 00/24] Add Realm support to QEMU-VMM Kohei Enju
2026-08-09 13:06   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728192630.240375-9-mathieu.poirier@linaro.org \
    --to=mathieu.poirier@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eblake@redhat.com \
    --cc=gshan@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lorenzo.pieralisi@linaro.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox