Re: [PATCH 1/8] KVM: selftests: Add Zhaoxin (ZX) CPU detection support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Type punning from `const char *` to `const u32 *` violates strict aliasing rules.
--

--- Patch [1]: [PATCH 1/8] KVM: selftests: Add Zhaoxin (ZX) CPU detection support ---
commit a6b3b2a2cfda9cc7037a7ac4f7079fa35f410950
Author: Frank Zhu <frankzhu@zhaoxin.com>

KVM: selftests: Add Zhaoxin (ZX) CPU detection support
    
Add infrastructure to detect Zhaoxin CPUs in KVM selftests. Zhaoxin
CPUs use vendor strings "CentaurHauls" or "  Shanghai  " and implement
VMX-compatible virtualization technology.

> diff --git a/tools/testing/selftests/kvm/include/x86/processor.h b/tools/testing/selftests/kvm/include/x86/processor.h
> index b161174ece453..9840b583877c3 100644
> --- a/tools/testing/selftests/kvm/include/x86/processor.h
> +++ b/tools/testing/selftests/kvm/include/x86/processor.h

[ ... ]

> @@ -744,6 +745,12 @@ static inline bool this_cpu_is_hygon(void)
>  	return this_cpu_vendor_string_is("HygonGenuine");
>  }
>  
> +static inline bool this_cpu_is_zx(void)
> +{
> +	return this_cpu_vendor_string_is("CentaurHauls") ||
> +	       this_cpu_vendor_string_is("  Shanghai  ");
> +}

[Severity: Low]
Does passing string literals to this_cpu_vendor_string_is() introduce a
strict aliasing violation?

Since this code is built as a selftest under tools/, standard
-fstrict-aliasing semantics apply rather than the core kernel's
-fno-strict-aliasing rules. Passing a const char * string literal to
this_cpu_vendor_string_is() results in an incompatible pointer cast to
const u32 * during evaluation.

Could this type punning lead to undefined behavior or compiler
misoptimizations?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730110524.2539316-1-ewanhai-oc@zhaoxin.com?part=1