Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Samiullah Khawaja <skhawaja@google.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Alex Williamson <alex@shazbot.org>, Shuah Khan <shuah@kernel.org>,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, Pratyush Yadav <pratyush@kernel.org>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	David Matlack <dmatlack@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Pranjal Shrivastava <praan@google.com>,
	Vipin Sharma <vipinsh@google.com>
Subject: Re: [PATCH v4 12/18] iommu/vt-d: Handle reattach of the restored domain
Date: Fri, 28 Aug 2026 11:35:46 -0300	[thread overview]
Message-ID: <20260828143546.GC3769797@ziepe.ca> (raw)
In-Reply-To: <bb7052d7-51fa-42e0-9eb5-ba4743956688@linux.intel.com>

On Fri, Aug 28, 2026 at 09:55:18AM +0800, Baolu Lu wrote:
> That looks reasonable to me. I have no concerns about keeping ATS
> enabled on preserved devices across kexec reboot, as long as the
> software state is synchronized in the new kernel.

The new kernel should issue an ATC flush when it changes away from the
inherented domain.

> By the way, is disabling ATS an option? 

No, many devices require ATS.

It is not that ATS and PRI are coupled, there are good reasons to do
ATS to pinned memory too.

PRI is a PITA, I continue to think PRI through the iommu was a
mistake. Devices that have device-specific PRI handling are fine
because that all lives in the VM. Devices relying on SMMU PRI
forwarding must also somehow not loose any PRI events across the kexec
and must ultimately inject all of them into the VM.

> The current design already requires disabling PCI/PRI during kexec,
> right? 

That is also not OK, but there certainly is a useful universe of VMs
that might pretend to use PRI but actually only use device specific
fault delivery.

So ignoring PRI for the moment is possibly OK. Someone using this
should understand what VM shapes thay are making and if that
limitation is OK.

Jason

  reply	other threads:[~2026-08-28 14:35 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08  2:27 [PATCH v4 00/18] iommu: Add live update state preservation Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 01/18] memfd: export memfd_get_seals() Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 02/18] iommu: Implement IOMMU Live update FLB callbacks Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 03/18] iommu/pages: Add APIs to preserve/unpreserve/restore iommu pages Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 04/18] iommupt: Implement preserve/unpreserve/restore callbacks Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 05/18] iommu: Implement IOMMU domain preservation Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 06/18] iommu: Implement device and IOMMU HW preservation Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 07/18] iommu/vt-d: Implement device and iommu preserve/unpreserve ops Samiullah Khawaja
2026-08-26  7:10   ` Baolu Lu
2026-08-26 20:46     ` Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 08/18] iommu/vt-d: Clear unpreserved context entries during shutdown Samiullah Khawaja
2026-08-26  8:05   ` Baolu Lu
2026-08-26 12:30     ` Pranjal Shrivastava
2026-08-26 20:37       ` Samiullah Khawaja
2026-08-26 20:30     ` Samiullah Khawaja
2026-08-27  6:09       ` Baolu Lu
2026-08-27 18:57         ` Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 09/18] iommu: Add APIs to get iommu and device preserved state Samiullah Khawaja
2026-08-12  6:29   ` Ankit Soni
2026-08-12 23:23     ` Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 10/18] iommu/vt-d: Restore IOMMU state and reclaimed domain ids Samiullah Khawaja
2026-08-27  7:22   ` Baolu Lu
2026-08-27 18:47     ` Samiullah Khawaja
2026-08-28  1:36       ` Baolu Lu
2026-08-08  2:27 ` [PATCH v4 11/18] iommu: Restore and reattach preserved domains to devices Samiullah Khawaja
2026-08-14 16:59   ` Ankit Soni
2026-08-14 19:46     ` Samiullah Khawaja
2026-08-17 15:32       ` Ankit Soni
2026-08-08  2:27 ` [PATCH v4 12/18] iommu/vt-d: Handle reattach of the restored domain Samiullah Khawaja
2026-08-27  8:12   ` Baolu Lu
2026-08-27 17:52     ` Samiullah Khawaja
2026-08-28  1:42       ` Baolu Lu
2026-08-28  1:55       ` Baolu Lu
2026-08-28 14:35         ` Jason Gunthorpe [this message]
2026-08-28 16:15           ` Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 13/18] iommu/vt-d: Preserve PASID table of preserved device Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 14/18] iommufd: Implement ioctl to mark HWPT for preservation Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 15/18] iommufd: Persist iommu hardware pagetables for live update Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 16/18] iommufd: Add APIs to preserve/unpreserve a vfio cdev Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 17/18] vfio/pci: Preserve the iommufd state of the " Samiullah Khawaja
2026-08-08  2:27 ` [PATCH v4 18/18] iommufd/selftest: Add test to verify iommufd preservation Samiullah Khawaja
2026-08-26  8:12 ` [PATCH v4 00/18] iommu: Add live update state preservation David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260828143546.GC3769797@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=akpm@linux-foundation.org \
    --cc=alex@shazbot.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=dmatlack@google.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=praan@google.com \
    --cc=pratyush@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=shuah@kernel.org \
    --cc=skhawaja@google.com \
    --cc=vipinsh@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox