From: Shivank Garg <shivankg@amd.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Hildenbrand <david@kernel.org>,
Shuah Khan <shuah@kernel.org>, Jim Mattson <jmattson@google.com>,
Peter Shier <pshier@google.com>,
Ricardo Koller <ricarkol@google.com>,
Ackerley Tng <ackerleytng@google.com>
Cc: <kvm@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Shivank Garg <shivankg@amd.com>
Subject: [PATCH v2 3/4] KVM: selftests: add get_numa_mem_nodes()
Date: Tue, 1 Sep 2026 08:22:40 +0000 [thread overview]
Message-ID: <20260901-gmem-selftests-fix-v2-3-5a273153354c@amd.com> (raw)
In-Reply-To: <20260901-gmem-selftests-fix-v2-0-5a273153354c@amd.com>
The xAPIC IPI test uses MPOL_F_MEMS_ALLOWED to get the memory nodes
available to the current process. Move the query to numaif.h as
get_numa_mem_nodes() so other KVM selftests can use it.
Call get_mempolicy() directly instead of using the assert-on-failure
kvm_get_mempolicy() wrapper. The xAPIC test already asserts its two
node requirement.
Signed-off-by: Shivank Garg <shivankg@amd.com>
---
tools/testing/selftests/kvm/include/numaif.h | 13 +++++++++++++
tools/testing/selftests/kvm/x86/xapic_ipi_test.c | 6 ++----
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/kvm/include/numaif.h b/tools/testing/selftests/kvm/include/numaif.h
index 29572a6d789c..98cf77cfc481 100644
--- a/tools/testing/selftests/kvm/include/numaif.h
+++ b/tools/testing/selftests/kvm/include/numaif.h
@@ -6,6 +6,7 @@
#include <dirent.h>
+#include <linux/bits.h>
#include <linux/mempolicy.h>
#include "kvm_syscalls.h"
@@ -75,6 +76,18 @@ static bool is_numa_available(void)
(errno != ENOSYS && errno != EPERM);
}
+static inline unsigned long get_numa_mem_nodes(void)
+{
+ unsigned long nodemask = 0;
+
+ /* Get set of first 64 numa nodes available */
+ if (get_mempolicy(NULL, &nodemask, BITS_PER_TYPE(nodemask), NULL,
+ MPOL_F_MEMS_ALLOWED))
+ return 0;
+
+ return nodemask;
+}
+
static inline bool is_multi_numa_node_system(void)
{
return is_numa_available() && get_max_numa_node() >= 1;
diff --git a/tools/testing/selftests/kvm/x86/xapic_ipi_test.c b/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
index e5706dd62d3b..b5f4ed671218 100644
--- a/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
+++ b/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
@@ -232,7 +232,7 @@ void do_migrations(struct test_data_page *data, int run_secs, int delay_usecs,
u64 *pipis_rcvd)
{
long pages_not_moved;
- unsigned long nodemask = 0;
+ unsigned long nodemask;
unsigned long nodemasks[BITS_PER_TYPE(nodemask)];
int nodes = 0;
time_t start_time, last_update, now;
@@ -247,9 +247,7 @@ void do_migrations(struct test_data_page *data, int run_secs, int delay_usecs,
fprintf(stderr, "Calling migrate_pages every %d microseconds\n",
delay_usecs);
- /* Get set of first 64 numa nodes available */
- kvm_get_mempolicy(NULL, &nodemask, BITS_PER_TYPE(nodemask),
- 0, MPOL_F_MEMS_ALLOWED);
+ nodemask = get_numa_mem_nodes();
fprintf(stderr, "Numa nodes found amongst first %lu possible nodes "
"(each 1-bit indicates node is present): %#lx\n",
--
2.43.0
next prev parent reply other threads:[~2026-09-01 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 8:22 [PATCH v2 0/4] KVM: guest_memfd: fix NUMA selftests Shivank Garg
2026-09-01 8:22 ` [PATCH v2 1/4] KVM: selftests: fix maxnode arguments in xapic_ipi_test Shivank Garg
2026-09-01 15:04 ` Sean Christopherson
2026-09-01 8:22 ` [PATCH v2 2/4] KVM: selftests: use BITS_PER_TYPE() for NUMA masks Shivank Garg
2026-09-01 8:22 ` Shivank Garg [this message]
2026-09-01 15:06 ` [PATCH v2 3/4] KVM: selftests: add get_numa_mem_nodes() Sean Christopherson
2026-09-01 8:22 ` [PATCH v2 4/4] KVM: selftests: use allowed NUMA nodes in guest_memfd_test Shivank Garg
2026-09-01 8:39 ` sashiko-bot
2026-09-01 9:38 ` Garg, Shivank
2026-09-01 15:07 ` Sean Christopherson
2026-09-01 17:28 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901-gmem-selftests-fix-v2-3-5a273153354c@amd.com \
--to=shivankg@amd.com \
--cc=ackerleytng@google.com \
--cc=david@kernel.org \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox