From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9D2142AF98 for ; Fri, 4 Sep 2026 19:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788552003; cv=none; b=UjV4dWwxcus3s2SRuVKRMTvntjwrBGSsh8AmnnCIOVdWOyvbDx2IUIAdbr/M+g4Psco+NAyqQu0L2bpqkmGBaymsPz/RDjIz7ZXqyz8W/R3OBjGdXzoH+o8ieCgD4+3VP0JYXXZ5TTYy9wGSB2fcpcmFGmwxMtgKVylcW5BVsD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788552003; c=relaxed/simple; bh=zjd5b/7UtrJcexJ7ZEgc0BXA9ixM3XyWJFnBq9YLcUU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iPywBCEDX9XPXaJX6wt4+HimP/0PoakiR1tzu9SCdGpklfVfQ2aZYmeGSwsRwUeTLcjgW7q2C7mEAirVFYGk0SddCZWsy8D5q0E23FsHPE+aF/oOyaHB5SFeLQO8EWRPh16jXvRcMDlQInp1y//dQp9Q9KMwSwFe4XoduLRbHSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TVPCaHks; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TVPCaHks" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788551997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QDNDYwMd+sicJrNeQLwCkPpcMo5x0mg7HS77Hu2tB3c=; b=TVPCaHkseCin1eNexP2ZXEenIeb5GRz9jcbcD57fwMzYoY5MD0MgANXifC2XZlyOea7vL1 j/CWQY2oiZofPjNSJAGQXx8SVMm8HRui9Kwux4J6r1a5UphOiR5aq+aqmXSWKFqaFUJImn eVt7oXLvA1gAJ7I5vACimV0fKCQospU= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-rlJDg5MPMPyZGvn8kkEQcQ-1; Fri, 04 Sep 2026 15:59:54 -0400 X-MC-Unique: rlJDg5MPMPyZGvn8kkEQcQ-1 X-Mimecast-MFC-AGG-ID: rlJDg5MPMPyZGvn8kkEQcQ_1788551992 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CCD4518D727A; Fri, 4 Sep 2026 19:59:52 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CD38E1955F01; Fri, 4 Sep 2026 19:59:51 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 04 Sep 2026 23:58:11 +0400 Subject: [PATCH v4 28/75] accel/kvm: convert OnOffSplit property to QAPI-aware registration Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260904-qom-qapi-v4-28-a985f168e938@redhat.com> References: <20260904-qom-qapi-v4-0-a985f168e938@redhat.com> In-Reply-To: <20260904-qom-qapi-v4-0-a985f168e938@redhat.com> To: qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Michael Roth , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org X-Developer-Signature: v=1; a=openpgp-sha256; l=2729; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=zjd5b/7UtrJcexJ7ZEgc0BXA9ixM3XyWJFnBq9YLcUU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqmyLJuojURDYhHvRBDUrMUtGTzoZLnEHAQllUk 1Ck2hCA8faJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCapsiyQAKCRDa6OEJdZac 5cQxD/9+e8yDxxe66LridYHbju1HzMaE86MiJE6LFJoj9ojsTwXY5yawqKNVNo1bap36Os6mLJm GzdCyidHvXTtQ1Sq6oi85PtBcD3/t33yiRIh/dUtQgyT9TO3mUHW2ZOz5zYNllP0AC/W4GHkaYg G2bktrKkQAEQU1NtZIujp7/ooLgsICf3UkrHc99N9ztFGSu8otS2aF0FWRRXhkD+Bd8PM0PYnvE GED+RJgDYeViOFVaxyyLGyI6zQi32KXBqprTHMyfsYl6B/azU9PsnlpT3yQmeEhcRGSdJbccagM 0WsBt6yH9c/ftrkT/8xNEucelIiJDNnE8bJ/4ix7jD6kSeTNjV0l9R3mWk1L1YeHrqYw+ufdaBj Vaj8Fc+mLGtxAk9lLdhcEZNKZaVGfXs+jkEziUVFWw9X3fEwG/DwzS8piqmWheakZeKtPomCPHz o0Xrq1OxOksMRv7N1hgFaaA9ShQl6x/yE4z/Fcc0zgGDtM1MN+reyGjVr6Ys0rgTfsocpP2aY02 AY2CxtOEMtXkDiQ4+pRperW/6pZxpk0Jb7hvqDTrHKShgahiYSZQAnsV8BS+pKQ1SHCAFohIGQy 9y5UiGrhkvVZLz1R8KI/btjJjLTsvmUc5rTX0AyJQIr2ggXdU5wkGG3UaPrkedPxiYQ3iG739zT EY6Ubpe5/IWf/EA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Convert the OnOffSplit property from manual visitor-based callbacks to property_add_qapi_enum(). Signed-off-by: Marc-André Lureau --- accel/kvm/kvm-all.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 83cbd120a847..e2cfbcf44046 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -46,6 +46,7 @@ #include "qapi/visitor.h" #include "qapi/qapi-types-common.h" #include "qapi/qapi-visit-common.h" +#include "qapi/qapi-type-infos-common.h" #include "system/reset.h" #include "qemu/guest-random.h" #include "system/hw_accel.h" @@ -4126,22 +4127,17 @@ static void kvm_set_kvm_shadow_mem(Object *obj, Visitor *v, s->kvm_shadow_mem = value; } -static void kvm_set_kernel_irqchip(Object *obj, Visitor *v, - const char *name, void *opaque, +static void kvm_set_kernel_irqchip(Object *obj, int value, Error **errp) { KVMState *s = KVM_STATE(obj); - OnOffSplit mode; if (s->fd != -1) { error_setg(errp, "Cannot set properties after the accelerator has been initialized"); return; } - if (!visit_type_OnOffSplit(v, name, &mode, errp)) { - return; - } - switch (mode) { + switch (value) { case ON_OFF_SPLIT_ON: s->kernel_irqchip_allowed = true; s->kernel_irqchip_required = true; @@ -4158,10 +4154,7 @@ static void kvm_set_kernel_irqchip(Object *obj, Visitor *v, s->kernel_irqchip_split = ON_OFF_AUTO_ON; break; default: - /* The value was checked in visit_type_OnOffSplit() above. If - * we get here, then something is wrong in QEMU. - */ - abort(); + g_assert_not_reached(); } } @@ -4278,11 +4271,12 @@ static void kvm_accel_class_init(ObjectClass *oc, const void *data) ac->has_memory = kvm_accel_has_memory; ac->allowed = &kvm_allowed; - object_class_property_add(oc, "kernel-irqchip", "on|off|split", - NULL, kvm_set_kernel_irqchip, - NULL, NULL); - object_class_property_set_description(oc, "kernel-irqchip", - "Configure KVM in-kernel irqchip"); + object_class_property_add_qapi_enum(oc, QAPI_ENUM_PROP( + .name = "kernel-irqchip", + .qapi_type = &OnOffSplit_type_info, + .set = kvm_set_kernel_irqchip, + .description = "Configure KVM in-kernel irqchip", + )); object_class_property_add(oc, "kvm-shadow-mem", "int", kvm_get_kvm_shadow_mem, kvm_set_kvm_shadow_mem, -- 2.55.0.543.g5ebe2ebe4ea8