From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28513DF59 for ; Tue, 8 Sep 2026 05:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788845985; cv=none; b=JTGoHnPXgCjg3C0k9+RE4QqEezik7FRoG5Hs3Jt+N0lEyc1ZGaGi5KfQZmtDycJcpfAoCL/rYWrI/CzpTkOHUWVHM6jJp/EGpiDn2W79Z6As5PQnEvu0t7y5II6EIzWIoJmWOpjOktmInlBHjZYUZhzyNWK0uns2TatxtL/KecA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788845985; c=relaxed/simple; bh=faRvsNO+3ng5yp7scD2ooEy+g3RDxAsErW36M1n5UGc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ccoD9hRlhNfMGVSgvPXetpgaJbCHtPgUmq/nL9dMjiWqimaHhfvmnvHeNASiGZJNf7sklS2AxAjU7z7BfOeYfjxYFIts6jFJguSmudS+2lHo174h94fsdK8K+sRYgC3IrFWm+oClFNjCnGOTCZbkAadG/JrrQrel76HCb9/pfbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m3xFggSd; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m3xFggSd" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49d036e0e99so15115255e9.1 for ; Mon, 07 Sep 2026 22:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788845979; x=1789450779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0Ry5IsRI3u6+OA2QrlJEuTetR9sltFKry3tbM/33hEE=; b=m3xFggSdQQMBIZKvFKAVdG3FM6JbMZdD5AVitmU25Sw/nIYzpGh1jHuCl3u2qGnSX5 wbtEyT9jpSW+bzep6HhLaFnJGg+uDwbTI4v3MFZuRwitHS179JMx27LRgxfUmzjeuh8u +PpXBYa0itQd4NkhxDzXKxEzcT7QpViN3cEn/UOjBjcS2hFhiMH0xf/H6FLLVfK2etrL +6kvJ15Pc2chJKXRTmHAZtnE2V1p6uhYPT4S5n3usGkcuIoLmnyT7BS7Oec6UosEJoNm qopxOEO/xlQyz0VI7aZSKdbbY4XX2t+2jeEWcqHt4j5goH0tv34Gaml7bxbJSjE4beak mg+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788845979; x=1789450779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0Ry5IsRI3u6+OA2QrlJEuTetR9sltFKry3tbM/33hEE=; b=FuiUn2FzXxbzTc+dFpsZK+z/kMq6dEC+ajtyMIkD2QBSrzqa0Ab8GW7lUN710fVJsW iPf1ELMFrvUWwhwYBqzCJuCbFh5nn8eH+z4dQ0ommDgD92F2LjlFNt7ho/Up80ftEkNF KIY4XAD2Ibwm2fkz2YN6mETtcFLVn/xMaZz8Q9TQHuj5c3LjT06BCf46t5ZjSDrAE+l/ zRT9xW0tQR7mC198y2l6167uhxIEoUCwgrVtYfGbzR+s3eJ4dfFOddhZszQgJEZQZ4ty pueD+Ggk9Ve0DgP50KsPKEC8Q/1F8pEKdt3kRq2afHENIyui3tcE6i9IjUe6WUZ5gY5N TliQ== X-Forwarded-Encrypted: i=1; AKwUvByzmXL4upuMkJMPasBr6UwJKznru/STa0b41JlGqe/rVIME2CRpwRlUwUXUOsPaMXG7P4I=@vger.kernel.org X-Gm-Message-State: AFuF++m18Z1ifB+XoJ39NpaZx+oIZPIvAeVZQXVqRrh/0IbbCp+UpFjY kWOuabLEH6oa8As8f00OKgydiej7Qum1wCZSSdNkfBRGXcTQbMnnnvtn X-Gm-Gg: AYBFou3iAnN6Bcj9hwzNWajXxvL/Y6O97hiwahefglb6Xn5wOACajM7tOgvnKSXcV7D wf2DmXlF3oLiBDCEaIAuKjz7GR3Dvwx5t+damrX4P6zto4RWM35B4DCxxyYdG8605lb3EViqleL UCvx671hPxLYgHN3Wom9cIVtA73cuwLCcMdveu2ppR+R+8YHepjg61dralhJe3ev8AF/a9PQtDQ 5TbyyU3yFHUgU1Z4OpnhRU8n7DXTI/8co7auuJD/UtcfI2WX4OWbve/S09zDu/jrg1wFi1OylIt /RnFvjvCLmCnT4mPF2V8zgywPAyFYuFfrltmP1IsGKG648ba6MpW0GwnG/5H1kdFPx5kytdU/as YisRAxLWW0Ler8o2KVRW3Zphg7ygBqmvc1tqPjGhuvMNPjY6icEdcFRaXWNJN1/RvYkdZfc8/Lm ejdZWhKaOWy4+X3vFOV1qNVqXyuZs+dyzTzU/cUO7yl7b3o8MTOGv8AwVOnJdydZkdDPReaS6Ra EHJqnK+eKzrz+6Aqq6vAOQJzlF1J5mHvDvAAGmFKWPkDdl6f8iFtxbxKV6kj46vEsre9kQjQJpQ n1O99Air4Kk6arLidEZRXzF6hLKfElSN9Qhvrk+Zjg== X-Received: by 2002:a05:600c:6748:b0:49c:fc6c:bdfa with SMTP id 5b1f17b1804b1-49cfc6cbfa2mr234336305e9.17.1788845978942; Mon, 07 Sep 2026 22:39:38 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-117-170-066.95.117.pool.telefonica.de. [95.117.170.66]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee7fec25sm523841335e9.13.2026.09.07.22.39.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Sep 2026 22:39:38 -0700 (PDT) From: Karl Mehltretter To: "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann Cc: Karl Mehltretter , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Dmitry Torokhov , Rusty Russell , Pawel Moll , Cornelia Huck , Halil Pasic , Eric Farman , Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , virtualization@lists.linux.dev, linux-input@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle Subject: [PATCH v3 1/6] virtio_ccw: fix synchronize_cbs() after interrupt fallback Date: Tue, 8 Sep 2026 07:38:12 +0200 Message-Id: <20260908053817.26065-2-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260908053817.26065-1-kmehltretter@gmail.com> References: <20260908053817.26065-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit virtio_ccw_synchronize_cbs() assumes the device uses adapter interrupts when vcdev->airq_info is not NULL. If registering adapter indicators fails, virtio_ccw_find_vqs() falls back to classic interrupts but can leave airq_info set. With VIRTIO_HARDEN_NOTIFICATION enabled, virtio_ccw_int_handler() invokes callbacks under vcdev->irq_lock. synchronize_cbs() instead takes the indicator area lock, so it does not synchronize with those callbacks. Use vcdev->is_thinint, which the fallback clears, to select the lock. Keep the airq_info check because is_thinint can be set before the first find_vqs() call, when airq_info is still NULL. Fixes: 3a232277c1ac ("virtio-ccw: implement synchronize_cbs()") Assisted-by: LLM Signed-off-by: Karl Mehltretter --- drivers/s390/virtio/virtio_ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index bab6cad3fd5c..b90299205698 100644 --- a/drivers/s390/virtio/virtio_ccw.c +++ b/drivers/s390/virtio/virtio_ccw.c @@ -1062,7 +1062,7 @@ static void virtio_ccw_synchronize_cbs(struct virtio_device *vdev) struct virtio_ccw_device *vcdev = to_vc_device(vdev); struct airq_info *info = vcdev->airq_info; - if (info) { + if (vcdev->is_thinint && info) { /* * This device uses adapter interrupts: synchronize with * vring_interrupt() called by virtio_airq_handler() -- 2.39.5 (Apple Git-154)