From: sashiko-bot@kernel.org
To: "Heiko Carstens" <hca@linux.ibm.com>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] s390/uv: Rework page allocation for guest variable storage area
Date: Tue, 15 Sep 2026 14:55:03 +0000 [thread overview]
Message-ID: <20260915145504.2D0E61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915144307.2367089-1-hca@linux.ibm.com>
> Alexander Gordeev reported that the allocation of pages of the
> guest variable storage area via the uv_alloc_range_cb() callback
> of apply_to_page_range() will cause problems as soon as s390 fully
> supports lazy mmu mode.
>
> Problem is that uv_alloc_range_cb() allocates pages with GFP_KERNEL while
> preemption would be disabled. This would result in reports like this:
>
> BUG: sleeping function called from invalid context at ./include/linux/sched/mm.h:322
> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 6092, name: qemu-kvm
> preempt_count: 1, expected: 0
> ...
> Call Trace:
> dump_stack_lvl+0xae/0x108
> __might_resched+0x1de/0x2f0
> [ ... ]
> potential future bug.
>
> Reported-by: Alexander Gordeev <agordeev@linux.ibm.com>
> Closes: https://lore.kernel.org/all/e9449c63-b8d2-4ed9-a184-7dcab3e8dfce-agordeev@linux.ibm.com
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915144307.2367089-1-hca@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-09-15 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:43 [PATCH] s390/uv: Rework page allocation for guest variable storage area Heiko Carstens
2026-09-15 14:55 ` sashiko-bot [this message]
2026-09-17 10:26 ` Alexander Gordeev
2026-09-17 19:35 ` Heiko Carstens
2026-09-18 11:43 ` Alexander Gordeev
2026-09-22 11:06 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915145504.2D0E61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox