From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3BB0502D4C; Thu, 17 Sep 2026 17:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789666329; cv=none; b=jVBkPRu1rqpJfq7Hxxs4DE2SJuCqCPAIw241CP8jOTmZo0DVfVlxdQWQtDamSdEA+2dauz22D7iGmstg5bx+FS0YSbr7wJsIK9R+P6FfHChyx5ff9b922YTC5EYEUKGiOA2igt+kRqjVW2yV11LUNz0jynEBwOxoI5hv26cKJdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789666329; c=relaxed/simple; bh=GAO9KibmnfrQxgnwITWH7iMqVZyTj9/wfGKSkT64HXs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=BvY8uHjVOv8XtfWlUigFxZztkVN7y5pmehTvtKvf04uKHZvvChpLTilwz9QRFs28DovXBy6eFSDkgtQwwSIluRz0xeVCbH7Kmw3+ENZg0OI1P1NblFMw1TlQuRkkhoVM+s8F4Yr9chzIy30ofxB8JxHqiPOlGeAeUBApZfEknYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hEKvOEmF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hEKvOEmF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA9751F00893; Thu, 17 Sep 2026 17:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789666328; bh=GAO9KibmnfrQxgnwITWH7iMqVZyTj9/wfGKSkT64HXs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=hEKvOEmFJhLn++y+Qg8OnPolhsNIJt+Pm8hxkX4/PGTmCd3lib+Qc/LpyNb0fD/0Z Z+VpCnoE2DeLrvwZBLJ1tD0v326OR9V68XFbyr3ix7fR615dBofSoIcDuIsP7oWeBO 6lHjdUyIi7m3k7HPUBQPniQJpu9N7taSKVjRS3RUZ5e5H4lc0YXseD0JxCjfHsIDV4 Id9NsuVU0A2H7/czKG20OApcysu6FW+xI+oKWHJZHkcaa8JLvAdiLxTnRcEHoZQHd5 T5uqs7nBx2JW5u2mJfX0aGV+e38PW0aLru9Ywkco5D9Di7uh18zRPeFWs87n88iSuR AIkXBG6v8IQag== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 05/40] mm/vma: ensure mmap_prepare doesn't set actions on a mergeable vma Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: "Marc Zyngier" , "Oliver Upton" , linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, "Christian Borntraeger" , "Alexander Gordeev" , linux-rdma@vger.kernel.org, "Heiko Carstens" , dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, selinux@vger.kernel.org, linux-perf-users@vger.kernel.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, bpf@vger.kernel.org, "Vasily Gorbik" In-Reply-To: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-5-4583d8a23bca@kernel.org> References: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-0-4583d8a23bca@kernel.org> <20260917-b4-mmap-prepare-vma-flag-sanify-v3-5-4583d8a23bca@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Sep 2026 17:32:07 +0000 Message-Id: <20260917173207.DA9751F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > When a user requests an mmap_action be performed in mmap_prepare, this > involves populating the VMA range with data. >=20 > However, if the VMA is mergeable, it might then mistakenly be merged with > another VMA without having populated the range. >=20 > Every mmap action currently available sets VMA flags such that the VMA > cannot be merged. >=20 > However, to ensure that no future mmap action falls foul of this, assert > that this is the case upon mmap_prepare validation. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260917-b4-mmap-pr= epare-vma-flag-sanify-v3-0-4583d8a23bca@kernel.org?part=3D5