Re: [PATCH v6 03/10] net/mlx5: Extract MLX5_SET/GET macros into mlx5_ifc_macros.h

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] net: mlx5: header mlx5_ifc_macros.h is not self-contained
--

commit 0109c2f8560d36d799afcabc263cdbca6ffef5b4
Author: Jason Gunthorpe <jgg@ziepe.ca>
Date:   Wed Sep 16 23:49:51 2026 +0000

net/mlx5: Extract MLX5_SET/GET macros into mlx5_ifc_macros.h

This commit extracts the MLX5_SET/GET macro family and internal helpers
from device.h into a new standalone header mlx5_ifc_macros.h. This allows
code that cannot include device.h, such as VFIO selftests, to use these
macros directly.

> device.h cannot be
> included by the VFIO selftest because it pulls in rdma/ib_verbs.h;
> the macros themselves depend only on endian helpers, BUILD_BUG_ON,
> and basic C types.

Is this commit message entirely accurate? The extracted macros also use
pr_debug in MLX5_GET_PR, which establishes an unstated dependency on
kernel printing utilities.

> diff --git a/include/linux/mlx5/mlx5_ifc_macros.h b/include/linux/mlx5/mlx5_ifc_macros.h
> new file mode 100644
> --- /dev/null
> +++ b/include/linux/mlx5/mlx5_ifc_macros.h
> @@ -0,0 +1,133 @@
[ ... ]
> + * Extracted from device.h so that code which cannot include device.h
> + * (e.g. selftests) can still use the MLX5_SET/GET family directly.
> + */
> +
> +#ifndef MLX5_IFC_MACROS_H
> +#define MLX5_IFC_MACROS_H
> +
> +/* Internal helpers -- 32-bit */

[Severity: Low]
Could this header cause build failures if it is included first in a new
source file or selftest? It relies on u32, BUILD_BUG_ON, offsetof, and
cpu_to_be32, but does not include <linux/types.h>, <linux/stddef.h>, or
<linux/build_bug.h> to satisfy those dependencies.

[ ... ]
> +#define MLX5_GET(typ, p, fld) ((be32_to_cpu(*((__be32 *)(p) +\
> +__mlx5_dw_off(typ, fld))) >> __mlx5_dw_bit_off(typ, fld)) & \
> +__mlx5_mask(typ, fld))
> +
> +#define MLX5_GET_PR(typ, p, fld) ({ \
> +	u32 ___t = MLX5_GET(typ, p, fld); \
> +	pr_debug(#fld " = 0x%x\n", ___t); \
> +	___t; \
> +})

[Severity: Low]
Does MLX5_GET_PR introduce a hidden dependency on kernel printing utilities?
Any selftest or driver pulling this header might fail to compile if the
printk headers are not already included, which seems to conflict with the
stated goal of keeping this header lightweight for selftests.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/0-v6-8af36cf7b73f+e2-mlx5st_jgg@nvidia.com?part=3