From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f12.google.com (mail-qk2-f12.google.com [74.125.230.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64422515987 for ; Fri, 18 Sep 2026 17:05:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789751131; cv=none; b=dx/YyDeqS/5U43TRNg13n/zyCFDq+gMuqfJTpCtlu7L/aAzQEeYolRkSW08rmqnzXo/XnVI+UczV7EjS7T9rtYvNqERTQYCAWnIZUOWBOA7YdzT9vD3kRNrzQe1vyCwqytD5U96lDTbv5PdCblSt/FhjozoZVNClyAWi9MRKMh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789751131; c=relaxed/simple; bh=CJUtrnr9lbLTqP4H/g58GCIz+hH13m2n3S92AYR7A28=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HFSkWnlwdTv5hMPexadgCfhuSVYxrI5RSAb+Slgg4Twx9VNYUjIq5tb+z1k0mVYnpj3lGQs65HHm++ZTvhXDlr79CcNPuzbD5IGEfDZSGfIfZt+yJT09RsSeHXDPXTHbdX4x6blbVIfQNkdQ70KUwb2mmqqWJxzw7Pf+lCJ0Aw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Zz16yMCv; arc=none smtp.client-ip=74.125.230.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Zz16yMCv" Received: by mail-qk2-f12.google.com with SMTP id af79cd13be357-939109fafddso66377585a.0 for ; Fri, 18 Sep 2026 10:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1789751128; x=1790355928; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zQcyEtFjPBr6Six+ddaDb/CoGlSZSKi7ev20pm6BxlM=; b=Zz16yMCvY0iYXnp4qSVkoFqfYheoD9f4m4mpImDpG1lBK5zjAXrDhEED+ZfgtMmKKb jys1jwEN8feW5ojbOVgRO7XgWW2iy67XVyUkEePMk5Xq6LEVrQtxqWBns2aRZejZ6kJU HZ3uRkD5CDOL6CSN2PRfm2xk3H9ERs6jPpBH6GG1MSBQXYB+kTGNA7u/HWhSBwG7Z8Zc 1GA+sGz6DLtPsTxDCzbUGJ/rXGjWsZvqLvGOJl6akUaZJu/X9tM8vqjyN91+zujqQvdc QgrytW/wV/mz66H73GTtDWEYG7ooveG8Pea/yxI0TY3AjvDlYVkLOtJPGvN28tqX534d oQLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789751128; x=1790355928; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=zQcyEtFjPBr6Six+ddaDb/CoGlSZSKi7ev20pm6BxlM=; b=fnQHd9vyn/B64d1bfsTYt3geQuYaRtljkHaOhXlMVDv1jvAmSO8tsLqgJNxGSHuXmp 4IEf+z3y9dIFnoLD6ETjWSx5o2FhKDu/PTdrC8NV0Sf4uFYSwfl1Vc/0S+OGQfE1MnOY 9PLF982mwwmlh+GjwLf+dzxr2gwB2Hj29yw68gvJLpL41m/Zb5grdb1KEfR6R92Ummw3 in/Dd9JS93g0EpPHc7E+cdSfTHSffNgKLk83fd+4YWmBBlyPJ+6VNdL4JTlyjOjtCSUX /ID5GthlBRPRFRnnqJRSYKJ4FewCYIomjvq/vtBniLWvV2gQ4/mpX5gp1SmmFNv2rz2c iUfQ== X-Forwarded-Encrypted: i=1; AKwUvBwBV11aeCagAoV2k5iLvcNBh3/WPSPig0BcHcqIVetr8V/024nqEEa3vmjtxE39KCV8ovs=@vger.kernel.org X-Gm-Message-State: AFuF++nNkA4O11OYPnbbnSMHIqNhafffFdti8ST6MQxVSFqzxLMxH+KW cKPnR5XGtPnvytzlr3tB5pqSsFVkDJIp9E9x9TnkPE4GiLfkiz8rPWHiWuSqGwfLZmQ= X-Gm-Gg: AYBFou0GIZAD9cP/aCnE9akmHiXcnsjO2ihEJlx7/4qOjLsdMwl2HPC2Y3XtFRUB7V5 6Dow7hOfxohi9p5ESRntDguINrwDDjVf8wQTzIH9tMDuLkdOke2oE//1r8ul2b2woSHgYVW4gCE HIWhjmf69kMXet/M5++wMAhsGqbIHxN3wbdl+UcstOVmd6hjLsoZJtVOUImWT0OtudrR5z9IQ/T kHJFRLVQ9mgvMvxGNbm1UtFLWfMilpb0HIJZ7en1IUM8M/ThWdzyZqgpAQfOKdrkNySF3Nz8xNd ozKmXabxLbrtPz94dAL8ZVlhyPGtRWYfc6WqYk+GENPidvXkGnTTaXAdv6D3oBn8XQ8YZCFtGmb pY/tm4j2hWr/0DGhns7uEGb1Ki3PZ5WrLvmJpE6ClDQGA0/DaSPUAwgKC+2bAfJUxJrN/WQBDpM ZOousqiVfX2xCNXn4VmqVDi4v8bwaky1c7tTm8z58kijvkPThD1KOzsynf3ctemR34N07XMwDh9 ZXaFE2JVx71dGHudcNbN0cPZpO6I8fv6DAoRiXVlei6UYqD0GWoxhdv X-Received: by 2002:a05:620a:440d:b0:93a:83d:1d26 with SMTP id af79cd13be357-93bdc6c7741mr490404585a.32.1789751128040; Fri, 18 Sep 2026 10:05:28 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93be0cc67e6sm187224885a.5.2026.09.18.10.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 10:05:25 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1x7c1c-00000001zVZ-3Nwz; Fri, 18 Sep 2026 14:05:24 -0300 Date: Fri, 18 Sep 2026 14:05:24 -0300 From: Jason Gunthorpe To: Thomas =?utf-8?Q?Hellstr=C3=B6m?= Cc: Leon Romanovsky , Bjorn Helgaas , Logan Gunthorpe , Chaitanya Kulkarni , Greg Kroah-Hartman , Jens Axboe , Alex Williamson , Ankit Agrawal , Jonathan Corbet , Shuah Khan , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Randy Dunlap , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, iommu@lists.linux.dev, Tushar Dave , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-rdma@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v6 18/18] RDMA/mlx5: Ask P2PDMA whether ATS takes a direct peer-to-peer route Message-ID: <20260918170524.GH11599@ziepe.ca> References: <20260914-fix-p2p-acs-v4-0-v6-0-5ef07ec9ef06@nvidia.com> <20260914-fix-p2p-acs-v4-0-v6-18-5ef07ec9ef06@nvidia.com> <321890690ce83d1943b2f678bd9bee9b8c895b66.camel@linux.intel.com> <20260918121500.GV13683@unreal> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Sep 18, 2026 at 03:42:28PM +0200, Thomas Hellström wrote: > > 1) Xe attachment check if pci_p2pdma_distance() returns OK for the > path. Then Xe always sets up dma-addresses using dma_map_resource(). Open coding pci_p2pdma_distance() in drivers is a hack. Using dma_map_resource() like this was never "allowed". We've fixed things so these hacks are not needed, the drivers need to move over to things like dma_buf_phys_vec_to_sgt() and the hmm helpers to use the DMA API correctly. > 1a) Let's say the importer (Xe) has ATS enabled, and the exporter is > supposed to map dma_addresses. > In between there is a switch that allows direct traffic. > Now with your patch series, How would the exporter know that Xe has ATS > enabled and therefore should return IOVA mappings rather than the BUS > addresses representing the shortcut. The thing that does the DMA map must be aware of what PCI TLPs the PCIe initiator will use to compute the proper P2P mapping mode. ATS always needs an IOVA but that still doesn't mean the P2P will work. > It seems to me that a pci-device settable flag "ATS always enabled" > should be enough to fix both issues? It should be be per-mapping to support the NIC workflow that isn't a global operation. Jason