Re: [PATCH RFC v4 3/4] RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] trace: incorrect TRACE_INCLUDE_PATH depth causes brittle include resolution
--

commit 2603329e3e16137c739dbffd2974c6bd447b6ee2
Author: GUO Ren (XuanTie) <guoren@kernel.org>

RISC-V: paravirt: pvqspinlock: Add trace point for pv_kick/wait

This commit adds tracepoints for paravirt qspinlock operations pv_kick and
pv_wait. These tracepoints allow observation of paravirt qspinlock behavior
via the paravirt trace event system.

> diff --git a/arch/riscv/kernel/trace_events_filter_paravirt.h b/arch/riscv/kernel/trace_events_filter_paravirt.h
> new file mode 100644
> index 0000000000000..8d57efda2c177
> --- /dev/null
> +++ b/arch/riscv/kernel/trace_events_filter_paravirt.h

[ ... ]

> +#endif /* _TRACE_PARAVIRT_H || TRACE_HEADER_MULTI_READ */
> +
> +#undef TRACE_INCLUDE_PATH
> +#undef TRACE_INCLUDE_FILE
> +#define TRACE_INCLUDE_PATH ../../../arch/riscv/kernel/

[Severity: Low]
Is this TRACE_INCLUDE_PATH definition too deep?

The three levels of parent directories (../../../) navigate outside the
kernel source tree relative to include/trace/define_trace.h. This currently
builds because the compiler falls back to searching the
-I$(srctree)/arch/riscv/include path, where the three directory levels happen
to perfectly cancel out the depth of the fallback path.

Could the include path be corrected to avoid compilation failures if the
include paths change or if built with compilers that evaluate fallbacks
differently?

> +#define TRACE_INCLUDE_FILE trace_events_filter_paravirt
> +
> +/* This part must be outside protection */
> +#include <trace/define_trace.h>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-pvqspinlock-v4-0-409a22aed6ef@kernel.org?part=3