From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56AB363C75 for ; Thu, 1 Oct 2026 21:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790890442; cv=none; b=n+EZknrwQ6v+bRRCZ99qZWSeUuYdZz2+ffavykgwyrAZtvexbWOscY//bHBItIxWgK1eJkCOyFPmVPvi3XO06m2WOahKqUvWO5M4aoQAIGUzJ697Wwmd+oIK0/nYlf9CNMYBbMxM85v2RAUR4qobI/uiRF/KXGZclaeVO0JNEEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790890442; c=relaxed/simple; bh=aoQY2n7UuHsEBO2b/7mwS2MVg8AzdCvjCqCqmkccQyQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=BZdUm5oSZi1dgzmr+BIB+UW4lzW0ZjFy/rjNyvyVPZtV75bJs0A91sPVYLdedolFS/60h6TxDmaVLFvuSP4enx3VTT6Fv7Yf/gdPjeQjy9+hOokI8vPC7+S7WHzUb49rUUM9vNRpxIPaP841j09dKFpAkI1Tu1lAUla8MbCrVic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--coltonlewis.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=C4QyQjR0; arc=none smtp.client-ip=209.85.167.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--coltonlewis.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="C4QyQjR0" Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-4a7de733fa9so2444421b6e.3 for ; Thu, 01 Oct 2026 14:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790890438; x=1791495238; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aoQY2n7UuHsEBO2b/7mwS2MVg8AzdCvjCqCqmkccQyQ=; b=C4QyQjR0Rc92htssClGS1cqTRLuedDdvrMqWrl45sKTSkV0N7gcYIp7AfwzGjfauog k54ep4YtTv9ARaLkAAG00FZn1KXHTbiWTuzxNVRMxBMMUpfNDEiRRGxFTMIbXnPNqxhz AVHFDp81d2Cp7P8PfeTiWIRDTVVgtHYvDN9ATmemT/WycA4RhVbP2jbfpBEOcrQyIf5w CCeisilSmC2G/6AteMCTugplztzABCcUEhr6j5C7AIVnYEdU+8h6eoIa/7AtrBVpscLi /uRVkexGkHLfgEac9r38Df0IiEvryYM4PYXRyKPSmsEB9E9iS7V/pBUge0OmxR0YdY96 HOSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790890438; x=1791495238; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aoQY2n7UuHsEBO2b/7mwS2MVg8AzdCvjCqCqmkccQyQ=; b=sQ5hoNYteIRT9trhpcImeOizclpVLsqun0QQsDKq/L8trmyoWxdW/HppFu20OD2xkR GNTOCGzY52HzeflO+eaFMB52XrcPbny8HnEHX9D+FQo/NQtNeyz3u279USoFmndGHxZu 2q2S+vdrguRlIPUfWT/+m7tAoOY7/Wmt9qqQ7JSMvOgu8znRnoULlu85tJGxF+BIh7sh lQ/EJtlrK6H4j2cPDBwG+VxOgFfNI/Flixu5LodM9bbvUeFaw/Ej94moTOE0UYackXSg o/8TuCFDUHGEf70DABfcIzKinnanI3spItVHi3dk5oEllGys1KSxypfHpit6qZJq3PmL ZxTg== X-Forwarded-Encrypted: i=1; AKwUvBy0XVaeqh77rus5pR1u0dTOTmoF+CbJigV1W/kvbry/P3ZF9QspPyL6rrAI9iS4abHia6k=@vger.kernel.org X-Gm-Message-State: AFuF++kgQA0Uk2fzBq9oYxEX72y9ebi33PndE6G/AhF5OMFGM5nKqYm4 m66ZUMyq1QSd/KTGCYvGfquACBh6Gq2FDEO6YIlPBtXbE+XdMwoevZ6oyzJ/NEXsSmUTTpxrNRi l+BcErqXQND/NP4Aa7KAgDxHvAg== X-Received: from ilbcx6.prod.google.com ([2002:a05:6e02:3c06:b0:50d:b50e:1675]) (user=coltonlewis job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6808:1211:b0:4b9:a829:f015 with SMTP id 5614622812f47-4f529d297bemr430489b6e.33.1790890437780; Thu, 01 Oct 2026 14:33:57 -0700 (PDT) Date: Thu, 1 Oct 2026 21:33:55 +0000 In-Reply-To: <8e47bb89-a894-4fd0-9f96-e11b5dea1972@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260924172928.2110956-1-coltonlewis@google.com> <8e47bb89-a894-4fd0-9f96-e11b5dea1972@linaro.org> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog Message-ID: <20261001213357.2088894-1-coltonlewis@google.com> Subject: Re: [PATCH v9 00/22] ARM64 PMU Partitioning From: Colton Lewis To: James Clark Cc: Colton Lewis , Marc Zyngier , Oliver Upton , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Fuad Tabba , Catalin Marinas , Will Deacon , Mark Rutland , Paolo Bonzini , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Robin Murphy , Zide Chen , Alexandru Elisei , Ganapatrao Kulkarni , Mingwei Zhang , Jonathan Corbet , Russell King , Shuah Khan , linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Hi James, On Wed, Sep 30, 2026 at 04:25:36PM +0100, James Clark wrote: > Looks good to me, everything seems to be working now: > > Tested-by: James Clark Thank you for testing and for all the reviews! > There are still a few Sashiko comments though, and one critical one about > racing with pseudo-NMI PMU interrupts that looked reasonable. I tried to > test it and reproduce an actual issue but couldn't, so maybe it's bogus. The "Critical" Sashiko comment on Patch 19/22 (claiming that clearing hardware PMOVSSET_EL0 loses overflow bits because the guest has direct untrapped access to PMOVSSET_EL0) is a false positive: Patch 09/22 sets HDFGRTR_EL2_PMOVS and HDFGWTR_EL2_PMOVS (and without FGT, MDCR_EL2.TPM is set), so guest accesses to PMOVSSET_EL0 and PMOVSCLR_EL0 always trap to pmu_reg_read() / pmu_reg_write(). The pseudo-NMI race comments on Patch 11/22 and Patch 19/22 are theoretically possible in a narrow 2-instruction RMW window because local_irq_save() does not mask GICv3 pseudo-NMIs, which explains why it wasn't reproducible in practice. In v10 I will make the PMOVSSET_EL0 shadow updates and vcpu->arch.mdcr_el2 assignment atomic, and address the other valid Sashiko findings. Thanks, Colton