Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Michael Roth <michael.roth@amd.com>
To: <qemu-devel@nongnu.org>
Cc: <kvm@vger.kernel.org>, <pbonzini@redhat.com>,
	<berrange@redhat.com>, <armbru@redhat.com>,
	<pankaj.gupta@amd.com>, <xiaoyao.li@intel.com>,
	<chao.p.peng@linux.intel.com>, <david@kernel.org>,
	<ashish.kalra@amd.com>, <ackerleytng@google.com>,
	<lpieralisi@kernel.org>
Subject: [PATCH v3 04/19] accel/kvm: Fix handling of conversion ranges with multiple MMIO holes
Date: Wed, 7 Oct 2026 08:41:28 -0500	[thread overview]
Message-ID: <20261007134323.1606088-5-michael.roth@amd.com> (raw)
In-Reply-To: <20261007134323.1606088-1-michael.roth@amd.com>

The current handling will properly handle MMIO checks for holes anchored
at the beginning of the conversion range, but misses subsequent holes.
The current handle_memory_hole() helper already processes all MMIO
ranges up to and including the sections found at each iteration, so
handle this by simply calling handle_memory_hole() for each additional
section/sub-range.

Fixes: c5d9425ef4da ("kvm/tdx: Don't complain when converting vMMIO region to shared")
Signed-off-by: Michael Roth <michael.roth@amd.com>
---
 accel/kvm/kvm-all.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index f0a79c9bda..2dfd14c257 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -3493,7 +3493,12 @@ int kvm_convert_memory(hwaddr start, hwaddr size, bool to_private)
         ret = handle_memory_hole(&section, to_private, start, &skip);
         if (ret || skip) {
             memory_region_unref(section.mr);
-            break;
+            if (ret) {
+                break;
+            }
+            size -= section_end - start;
+            start = section_end;
+            continue;
         }
 
         ret = kvm_convert_section(&section, to_private);
-- 
2.43.0


  parent reply	other threads:[~2026-10-07 13:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 13:41 [PATCH v3 00/19] guest_memfd: support in-place memory conversion Michael Roth
2026-10-07 13:41 ` [PATCH v3 01/19] accel/kvm: Add helper for handling conversions of MMIO holes Michael Roth
2026-10-07 13:41 ` [PATCH v3 02/19] accel/kvm: Fix kvm_convert_memory() calls crossing memory regions Michael Roth
2026-10-07 13:41 ` [PATCH v3 03/19] accel/kvm: Fix handling of MMIO holes at start of conversion ranges Michael Roth
2026-10-07 13:41 ` Michael Roth [this message]
2026-10-07 13:41 ` [PATCH v3 05/19] accel/kvm: Use dedicated helper for creating private-only gmem instances Michael Roth
2026-10-07 13:41 ` [PATCH v3 06/19] [NOT-FOR-MERGE] linux-headers: Update headers for v13 of in-place conversion kernel support Michael Roth
2026-10-07 13:41 ` [PATCH v3 07/19] accel/kvm: Add CGS flag to control in-place conversion support Michael Roth
2026-10-07 13:41 ` [PATCH v3 08/19] system/memory: Re-use memory-backend-guest-memfd inode for private memory Michael Roth
2026-10-07 13:41 ` [PATCH v3 09/19] accel/kvm: Handle guest_memfd flags internally when creating instances Michael Roth
2026-10-07 13:41 ` [PATCH v3 10/19] system/memory: Default to guest_memfd for RAM for in-place conversion Michael Roth
2026-10-07 13:41 ` [PATCH v3 11/19] accel/kvm: Move post-conversion updates to a separate helper Michael Roth
2026-10-07 13:41 ` [PATCH v3 12/19] accel/kvm: Re-order attribute notifications for in-place conversion Michael Roth
2026-10-07 13:41 ` [PATCH v3 13/19] accel/kvm: Support shared/private conversions via guest_memfd ioctls Michael Roth
2026-10-07 13:41 ` [PATCH v3 14/19] accel/kvm: Don't default to private attributes for in-place conversion Michael Roth
2026-10-07 13:41 ` [PATCH v3 15/19] i386/sev: Update SNP_LAUNCH_UPDATE " Michael Roth
2026-10-07 13:41 ` [PATCH v3 16/19] i386/sev: Update CPUID failure handling " Michael Roth
2026-10-07 13:41 ` [PATCH v3 17/19] accel/kvm: Disable discard " Michael Roth
2026-10-07 13:41 ` [PATCH v3 18/19] i386/sev: Add sev-snp-guest parameter to enable " Michael Roth
2026-10-08  6:11   ` Markus Armbruster
2026-10-07 13:41 ` [PATCH v3 19/19] hostmem: Automatically select set guest-memfd=on for " Michael Roth
2026-10-08  6:14   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007134323.1606088-5-michael.roth@amd.com \
    --to=michael.roth@amd.com \
    --cc=ackerleytng@google.com \
    --cc=armbru@redhat.com \
    --cc=ashish.kalra@amd.com \
    --cc=berrange@redhat.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=david@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=pankaj.gupta@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox