From: David Laight <david.laight.linux@gmail.com>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Wang Haoran <haoranwangsec@gmail.com>,
jasowangio@gmail.com, kvm@vger.kernel.org,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
eperezma@redhat.com
Subject: Re: [BUG] vhost/vringh: __get_user without access_ok leaks kernel memory via vDPA passthrough
Date: Tue, 20 Oct 2026 10:21:34 +0100 [thread overview]
Message-ID: <20261020102134.745ff48a@pumpkin> (raw)
In-Reply-To: <CAHk-=wjxtzD1TXZr5iWu0p1+Hu0YZP7jbNSwFkp7AJYmhzhVCA@mail.gmail.com>
On Mon, 19 Oct 2026 20:51:43 -1000
Linus Torvalds <torvalds@linuxfoundation.org> wrote:
> On Mon, 19 Oct 2026 at 20:31, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > The following seems to work for me. Testing would be appreciated.
>
> I have a whole branch that removes __get_user() and __put_user() entirely.
There should also be very few (if any) access_ok() calls outside of the code
that implements user copies.
David
>
> Somebody should check that I did it right. But I didn't want to do the
> pagefault_disable() around the vringh_notify() part, so it's not quite
> the same as yours.
>
> Let me just push it out. I was going to let it simmer, but your email
> made me go "I should just let more people look at it".
>
> Mind taking a look at the 'uaccess-cleanups' branch?
>
> It builds for me. That's all the testing it has gotten so far. Blush.
>
> Linus
>
next prev parent reply other threads:[~2026-10-20 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 7:23 [BUG] vhost/vringh: __get_user without access_ok leaks kernel memory via vDPA passthrough Haoran Wang
2026-10-15 7:42 ` Eugenio Perez Martin
2026-10-17 21:59 ` David Laight
2026-10-18 19:24 ` Michael S. Tsirkin
2026-10-18 19:48 ` David Laight
2026-10-18 21:42 ` Michael S. Tsirkin
2026-10-18 21:57 ` Michael S. Tsirkin
[not found] ` <CAHk-=wjneFJ7XmZ6ux-LsHq4apDgANcKfERztmAG9sGVY_TxAg@mail.gmail.com>
2026-10-18 22:13 ` Michael S. Tsirkin
2026-10-18 23:12 ` Linus Torvalds
2026-10-18 20:34 ` Linus Torvalds
2026-10-18 21:11 ` Linus Torvalds
2026-10-18 21:41 ` Michael S. Tsirkin
2026-10-18 21:43 ` Michael S. Tsirkin
[not found] ` <376ef9d0-b03f-4f85-aee5-46cf20eb00ae@gmail.com>
2026-10-20 6:30 ` Michael S. Tsirkin
2026-10-20 6:51 ` Linus Torvalds
2026-10-20 7:27 ` Michael S. Tsirkin
2026-10-20 9:21 ` David Laight [this message]
2026-10-20 9:22 ` Eugenio Perez Martin
2026-10-20 9:41 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020102134.745ff48a@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=eperezma@redhat.com \
--cc=haoranwangsec@gmail.com \
--cc=jasowangio@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox