From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793116029; b=uEyhjWJw4P8llw4LHPTz5RMmx6mOfNv86SpcIrtZqiRLey1znOqA4+XBb7AnJ10X9MA7 mJQeEZsdqkAsUp5IPnyOw7bEsdrFeZRyrzXwssp5umBlwNhuRvvCqIIsGQcoZX46PXl91 Dcyys3AHoPMGw2CQeLC2+RFzUjsucV/JfEEHDT1RXwI8hhSd9JP2ulXWJv8tl00E61VNN Vmt/DXomDbXSS8n8qGRtPygBRMDgRFHEDm+4toJK6JK+9hePQJgoILxC7xhv/TkKNNOVX GAllxbRqYofCWe8uumdeOt/4dJK8sYlcXQ1S0t9LPnBTabb3KY8yV4t3WffBDXeWcWg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793116029; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=I9tKrbL54EVqcIFPPtB7uxrxNAXJtibM80HAzpUcWLM=; b=0jyKApvjp7RWoKdCWIWv6fV9roVLTf11qG6ePRzFnWzkeok7g/TThAFMc1xb0ZHtysjz hqhSo3AuiMIfbkP787mO3AnfxskIOa7sMlCShdPMR5+IpHEkyTwuvJ00UpnyUR4SI+wQM 8VPsy+lIaS7CbZCDvToM9cYm709sEn/XYYkfikXw/yZkkZU1Dm06khPX2dp0o86pF4AAa 9lfNj73FalEkEVi6gyrp3FpkKzSuIV2t/RsRjDCWSxdTm5cDXzfRNIuASNI7Uz4CZBLn/ 156r8/7rKaXMGUmbqvROiOE3xae1PUuolFsaLFxQuDfQ/1Gn37VRR6gAlknlBLNvPIQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=yRmVMWZO; arc=none smtp.remote-ip=209.85.221.52 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C09260A2613 for ; Tue, 27 Oct 2026 15:47:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0C09260A2613 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=yRmVMWZO Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-48df0fa43c5so879585f8f.0 for ; Tue, 27 Oct 2026 08:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793116027; x=1793720827; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I9tKrbL54EVqcIFPPtB7uxrxNAXJtibM80HAzpUcWLM=; b=yRmVMWZOSgYOouFJ3XXj5aw0KaSgckQYEvRlJmiAj5iMaleGe121rSWoqxNhtg5N14 hX5jZ8iCw6nxxKWsfk/jfcRNcK4D5RPZtrs/ZHpXMxQdJwUxLv/D02GyG9ly0itjET0l QYJWU9CIDnW5SAScmWpFXXCYGxlIWaup/cyg16ZIu7O9e5Jaz34+seo9RmRvx9F/GpWp 7s0vaOvPuzftBCOXtxey5t+MSQh2D/edaVW4fxD59EZn55DdlWfybRHvnQ7jdJCtNXnA aMKrIfeza+LyTAm3fNuJlj9oeBD8wLhxs5ehug6UvNlcUaWev8fOiNZ+aFqThE2FqT+j rlEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793116027; x=1793720827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=I9tKrbL54EVqcIFPPtB7uxrxNAXJtibM80HAzpUcWLM=; b=2lyIxqkN4BPeHLeaGPi3LXcsEKzT/DkjghjaWzT4b7oTfHxfz3AJzpeUqHGAU0sgtV UjanBRlqXljOfC/d9W8xvOF0Tv4IRoacLgwBly37M7+/rznITpDGfZKlq/xDRSrlUv+R /el5Arp03UPC1dswGX4EOaJn4nV7EqQ+E6+PtgI3O5hHjbinV0olKabdk4jtwQIgZQAP izaMF7itwk9oSpDpKsVHnAV+r/2WvexQM70SsS4IjSjs814SErc4WVmO6FXRVGiAQ8Jt jD+XBbYPy87VzIkST7n5PP9aAjBCYJvwNr0noKod2xqMs2UtIyACAOLtZHbqU+tCiLsj 1yLQ== X-Forwarded-Encrypted: i=1; AKwUvBxSq4D9HLMdDGiGy5laBWF3qf+KtkhuDH7bylscWwUOJAs641AhxUp1HI45SpYhr2wDtAA=@vger.kernel.org X-Gm-Message-State: AFq9FYKjqrreErcin3EmceVRX46Kf6HtjgfyDMPficSiWCX3mfXtFYKL /pstN1HO2K5UlGI/Ugg555fC/X4Kcs4BGEpFM3r+1KUs/lcljpHE/N+Q X-Gm-Gg: AYBFou0QYo7eXUWgM1wC3GCz9ua92L96T98i7I63tlmywKD92ebvtugkRSqvg4jiSOq cb0awjqSy2RCMqr8DDMobhJ/fnwCr3nXQsOzoWx1rRvNE8LzZDAd2BLV5xrGn7ZCdoot1RjfYcV D88eHrI95GXsf3tuV/pcf9YC/mQbCPZG7D+KUBAdFE+yyAzqcFE7pN99tutlDrMZMwBy9LK4ta9 vYtYg14iD/4AOZ91qtKnjdWuj0Q4KOuaF5061xKPwprZTNhc1XIp96WKfqrBMpUF0dzp8jQjUEp CKcMA0zH9kk9v3qGu7CkFQrt1UgJm2tM7zxDhBIgulkXj0DEpwPPAh5vhj0g8U4LwqGC+/hhuEm T165uCqZ7ERv8ahWGzmRR53jRplHeSlqMi86zgIgmxR/QlGk/1etvCSB3ULQYr7FJ67Rb3X54s+ nmFFaaVBjQPcXmJQ08H0uQsJ+wxW3tvpDSKokyfwutjeWXfCmRW/C4FekymQFaIagVmRPlnVlSz egzDYulPvd1ql3JngCp3iFB1uev0uDaB127qpJj9Bb0sG7/d3nuYNJiQ1PlcNsF0bu4Wl1LFFIy vhZL4fU7+F8WA5jqkyapnv05V8GyDDEjIcRpMdQSEzoehVnvbi3byFdsS1nMh+Qykk/qBqyd8Sd pT/SXKtaabHkI0z8VlUgXchKmFUNlRK7GOqs/5w== X-Received: by 2002:adf:ebcd:0:b0:48e:4ad2:32e0 with SMTP id ffacd0b85a97d-48e55a5a8bemr4605062f8f.29.1793116027147; Tue, 27 Oct 2026 08:47:07 -0700 (PDT) Received: from dev-dsk-fgriffo-1c-93421965.eu-west-1.amazon.com (54-240-197-234.amazon.com. [54.240.197.234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ebcb958sm23845574f8f.21.2026.10.27.08.47.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2026 08:47:06 -0700 (PDT) From: Fred Griffoul To: Ackerley Tng , Paolo Bonzini , Sean Christopherson , Jason Gunthorpe , Kevin Tian Cc: Alex Williamson , Alexander Graf , Alexander Viro , Alexey Kardashevskiy , Andrew Morton , "Aneesh Kumar K . V" , Ashish Kalra , Baolin Wang , Baolu Lu , Bill Wendling , Borislav Petkov , Catalin Marinas , Christian Brauner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Connor Williamson , Dave Hansen , Dave Jiang , David Hildenbrand , David Rientjes , David Woodhouse , Erdem Aktas , Frank van der Linden , Gregory Price , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Jacob Pan , James Houghton , Jan Kara , Jianxiong Gao , Joerg Roedel , Joey Gouly , John Starks , Jonathan Corbet , Justin Stitt , Lorenzo Stoakes , Marc Zyngier , Michael Roth , Mike Rapoport , Nathan Chancellor , Nick Desaulniers , Nicolin Chen , Oliver Upton , Pratyush Yadav , Randy Dunlap , Robin Murphy , Samiullah Khawaja , Shuah Khan , Steffen Eiden , Steven Price , Suzuki K Poulose , Tarun Sahu , Thomas Gleixner , Tom Lendacky , Tycho Andersen , Vishal Annapurve , Vlastimil Babka , Will Deacon , Xu Yilun , Yan Zhao , Zenghui Yu , x86@kernel.org, Shuah Khan , Fuad Tabba , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, iommu@lists.linux.dev Subject: [RFC PATCH 06/14] KVM: guest_memfd: Report the size of holes in export lookups Date: Tue, 27 Oct 2026 15:46:41 +0000 Message-ID: <20261027154649.91571-7-griffoul@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261027154649.91571-1-griffoul@gmail.com> References: <20261022-gmem-alternative-providers-v2-0-5dd1dc6c660a@google.com> <20261027154649.91571-1-griffoul@gmail.com> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Fred Griffoul A lookup reports a hole as a single page, so a consumer walks a large private or unbacked range one page at a time, and cannot map a large hole with one entry, e.g. to a scratch page. Report the largest aligned hole around the page, up to the order the caller asks for. The search checks one half-block at a time, so it costs about one lookup per page of the hole it finds. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Fred Griffoul --- virt/kvm/guest_memfd.c | 48 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index 015f6657c386..1c5826c5384e 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -1417,6 +1417,48 @@ static int __kvm_gmem_export_lookup(struct inode *inode, pgoff_t index, return 0; } +/* Does no page of [start, start + nr) have a frame to map? */ +static bool kvm_gmem_export_is_hole(struct inode *inode, pgoff_t start, + pgoff_t nr) +{ + unsigned long pfn; + pgoff_t index; + u32 attrs; + int order; + + for (index = start; index < start + nr; index++) { + order = 0; + if (__kvm_gmem_export_lookup(inode, index, &pfn, &order, + &attrs) != -ENOENT) + return false; + cond_resched(); + } + return true; +} + +/* + * The order, up to @max_order, of the largest naturally aligned block around + * @index that lies inside the file and has no frame to map. Each step checks + * only the half of the larger block that does not hold @index. + */ +static int kvm_gmem_export_hole_order(struct inode *inode, pgoff_t index, + int max_order) +{ + pgoff_t npages = i_size_read(inode) >> PAGE_SHIFT; + int order; + + for (order = 0; order < max_order; order++) { + pgoff_t n = 1UL << order; + pgoff_t first = round_down(index, 2 * n); + + if (first + 2 * n > npages || + !kvm_gmem_export_is_hole(inode, index & n ? first : first + n, + n)) + break; + } + return order; +} + /** * kvm_gmem_export_lookup_pfn - The frame behind a shared page. * @e: The export. @@ -1424,7 +1466,8 @@ static int __kvm_gmem_export_lookup(struct inode *inode, pgoff_t index, * @pfn: The frame. * @max_order: In: the largest order the caller can map. Out: the order of * the naturally aligned block around @index that is contiguous, - * shared and of the same @attrs; 0 for -ENOENT. + * shared and of the same @attrs or, for -ENOENT, that has no + * frame to map at all. * @attrs: The GUEST_MEMFD_PFN_* attributes of the block. * * Takes no reference and allocates nothing, and may be called from the @@ -1438,6 +1481,7 @@ int kvm_gmem_export_lookup_pfn(struct guest_memfd_export *e, pgoff_t index, unsigned long *pfn, int *max_order, u32 *attrs) { struct inode *inode = file_inode(e->file); + int order = *max_order; int r; if (index >= i_size_read(inode) >> PAGE_SHIFT) @@ -1445,7 +1489,7 @@ int kvm_gmem_export_lookup_pfn(struct guest_memfd_export *e, pgoff_t index, r = __kvm_gmem_export_lookup(inode, index, pfn, max_order, attrs); if (r == -ENOENT) - *max_order = 0; + *max_order = kvm_gmem_export_hole_order(inode, index, order); return r; } EXPORT_SYMBOL_GPL(kvm_gmem_export_lookup_pfn); -- 2.47.3