From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Goldish Subject: Re: [Autotest] [PATCH] Specify the system UUID for VM Date: Wed, 29 Jul 2009 08:46:53 -0400 (EDT) Message-ID: <2030247853.1166561248871613315.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> References: <6ac58f4f0907290536m1f7895f2p74d07c17837f8bb1@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: autotest@test.kernel.org, kvm@vger.kernel.org, Avi Kivity To: Lucas Meneghel Rodrigues Return-path: Received: from mx1.redhat.com ([66.187.233.31]:39004 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754331AbZG2Mqz convert rfc822-to-8bit (ORCPT ); Wed, 29 Jul 2009 08:46:55 -0400 In-Reply-To: <6ac58f4f0907290536m1f7895f2p74d07c17837f8bb1@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: ----- "Lucas Meneghel Rodrigues" wrote: > On Wed, Jul 29, 2009 at 9:18 AM, Avi Kivity wrote: > > On 07/16/2009 01:26 PM, Yolkfull Chow wrote: > >> > >> Signed-off-by: Yolkfull Chow > >> --- > >> =C2=A0client/tests/kvm/kvm_vm.py | =C2=A0 11 +++++++++++ > >> =C2=A01 files changed, 11 insertions(+), 0 deletions(-) > >> > >> diff --git a/client/tests/kvm/kvm_vm.py > b/client/tests/kvm/kvm_vm.py > >> index 503f636..895049e 100644 > >> --- a/client/tests/kvm/kvm_vm.py > >> +++ b/client/tests/kvm/kvm_vm.py > >> @@ -113,6 +113,13 @@ class VM: > >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.qemu_path =3D qemu_path > >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.image_dir =3D image_dir > >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.iso_dir =3D iso_dir > >> + > >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0if params.get("uuid"): > >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if params.get("uuid") =3D= =3D "random": > >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0uuid =3D = os.popen("cat > >> /proc/sys/kernel/random/uuid").readline() > >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.uuid= =3D uuid.strip() > >> > > > > instead of os.popen("cat ..."), you can open the file directly: > > > > =C2=A0 uuid =3D file('/proc/.../uuid').readline() >=20 > Oooops... I didn't notice this little issue. Will make a quick patch > to change it, thanks Avi! I think I already commented on this and Yolkfull posted a new patch, and that patch is the one that got applied. That's what I see in my local tree anyway. > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest