From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH v1] s390x: add stidp interception test Date: Thu, 22 Jun 2017 09:51:17 +0200 Message-ID: <20cf6ffc-5bfd-b2d6-b8b7-a67d9cc49ec7@redhat.com> References: <20170619091538.10157-1-david@redhat.com> <20170619173528.GB10325@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Thomas Huth , kvm@vger.kernel.org, Paolo Bonzini , Christian Borntraeger To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59233 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbdFVHvU (ORCPT ); Thu, 22 Jun 2017 03:51:20 -0400 In-Reply-To: <20170619173528.GB10325@potion> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 19.06.2017 19:35, Radim Krčmář wrote: > 2017-06-19 14:21+0200, David Hildenbrand: >> On 19.06.2017 12:44, Thomas Huth wrote: >>> On 19.06.2017 11:15, David Hildenbrand wrote: >>>> @@ -105,6 +105,32 @@ static void test_stap(void) >>>> + report("id.version == 0 || id.version == 0xff)", >>> >>> Superfluous parenthesis -----------------------------^ >> >> Whops, yes, thanks. > > This pattern could use a macro ;) > > #define report(x) report(#x, x) After thinking 5 minutes about a possible name for this and not liking the results, I decided to simply go for a text output as Thomas suggested for now. :) -- Thanks, David