Re: [PATCH] KVM: x86/mmu: Do not create SPTEs for GFNs that exceed host.MAXPHYADDR

Paolo Bonzini
2022-05-02T11:52:21Z

On 5/2/22 13:12, Kai Huang wrote:
>> - if (unlikely(!enable_mmio_caching)) {
>> + if (unlikely(!enable_mmio_caching) ||
>> +     unlikely(fault->gfn > kvm_mmu_max_gfn_host())) {
> Shouldn't we check fault->gfn against cpuid_maxphyaddr(vcpu) instead of
> kvm_mmu_max_gfn_host() here?

No, the point of this check is to handle the case where
kvm_mmu_max_gfn_host() is smaller than cpuid_maxphyaddr().

Paolo