From: Paolo Bonzini <pbonzini@redhat.com>
To: Kai Huang <kai.huang@intel.com>,
dave.hansen@intel.com, bp@alien8.de, tglx@linutronix.de,
peterz@infradead.org, mingo@redhat.com, hpa@zytor.com,
thomas.lendacky@amd.com
Cc: x86@kernel.org, kas@kernel.org, rick.p.edgecombe@intel.com,
dwmw@amazon.co.uk, linux-kernel@vger.kernel.org,
seanjc@google.com, kvm@vger.kernel.org,
reinette.chatre@intel.com, isaku.yamahata@intel.com,
dan.j.williams@intel.com, ashish.kalra@amd.com,
nik.borisov@suse.com, chao.gao@intel.com, sagis@google.com
Subject: Re: [PATCH v4 0/7] TDX host: kexec/kdump support
Date: Tue, 22 Jul 2025 15:50:20 +0200 [thread overview]
Message-ID: <20f12925-1c9c-4da7-b6b5-a0e9d4125c99@redhat.com> (raw)
In-Reply-To: <cover.1752730040.git.kai.huang@intel.com>
On 7/17/25 23:46, Kai Huang wrote:
> This series is the latest attempt to support kexec on TDX host following
> Dave's suggestion to use a percpu boolean to control WBINVD during
> kexec.
>
> Hi Boris/Tom,
>
> As requested, I added the first patch to cleanup the last two 'unsigned
> int' parameters of the relocate_kernel() into one 'unsigned int' and pass
> flags instead. The patch 2 (patch 1 in v3) also gets updated based on
> that. Would you help to review? Thanks.
>
> I tested that both normal kexec and preserve_context kexec works (using
> the tools/testing/selftests/kexec/test_kexec_jump.sh). But I don't have
> SME capable machine to test.
>
> Hi Tom, I added your Reviewed-by and Tested-by in the patch 2 anyway
> since I believe the change is trivial and straightforward). But due to
> the cleanup patch, I appreciate if you can help to test the first two
> patches again. Thanks a lot!
I guess we're just waiting for a v5 with testb and an augmented comment
in patch 1?
(Frankly, I am not sure I see any improvement with respect to v3. When
assembly is involved, what looks like a cleanup can make register usage
more messy. But since the code is there, I'm not going to ask Kai or
anyone else to do anything).
Paolo
prev parent reply other threads:[~2025-07-22 13:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 21:46 [PATCH v4 0/7] TDX host: kexec/kdump support Kai Huang
2025-07-17 21:46 ` [PATCH v4 1/7] x86/kexec: Consolidate relocate_kernel() function parameters Kai Huang
2025-07-21 14:40 ` Tom Lendacky
2025-07-21 21:20 ` Huang, Kai
2025-07-21 21:27 ` Tom Lendacky
2025-07-21 21:36 ` Huang, Kai
2025-07-21 23:05 ` H. Peter Anvin
2025-07-21 23:29 ` Huang, Kai
2025-07-21 23:42 ` Huang, Kai
2025-07-22 0:44 ` H. Peter Anvin
2025-07-22 0:53 ` Huang, Kai
2025-07-23 8:13 ` Huang, Kai
2025-07-22 14:58 ` Borislav Petkov
2025-07-23 2:13 ` Huang, Kai
2025-07-17 21:46 ` [PATCH v4 2/7] x86/sme: Use percpu boolean to control WBINVD during kexec Kai Huang
2025-07-17 21:46 ` [PATCH v4 3/7] x86/virt/tdx: Mark memory cache state incoherent when making SEAMCALL Kai Huang
2025-07-22 14:52 ` Chao Gao
2025-07-23 1:59 ` Huang, Kai
2025-07-23 6:47 ` Chao Gao
2025-07-17 21:46 ` [PATCH v4 4/7] x86/kexec: Disable kexec/kdump on platforms with TDX partial write erratum Kai Huang
2025-07-17 21:46 ` [PATCH v4 5/7] x86/virt/tdx: Remove the !KEXEC_CORE dependency Kai Huang
2025-07-17 21:46 ` [PATCH v4 6/7] x86/virt/tdx: Update the kexec section in the TDX documentation Kai Huang
2025-07-17 21:46 ` [PATCH v4 7/7] KVM: TDX: Explicitly do WBINVD when no more TDX SEAMCALLs Kai Huang
2025-07-21 13:08 ` [PATCH v4 0/7] TDX host: kexec/kdump support Tom Lendacky
2025-07-21 14:50 ` Tom Lendacky
2025-07-21 21:30 ` Huang, Kai
2025-07-21 21:30 ` Huang, Kai
2025-07-22 13:50 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20f12925-1c9c-4da7-b6b5-a0e9d4125c99@redhat.com \
--to=pbonzini@redhat.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).