From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Subject: Re: [PATCH v11 10/22] vfio iommu type1: Add support
 for mediated devices
Date: Mon, 14 Nov 2016 10:49:10 +0800
Message-ID: <21031.2476302081$1505294555@news.gmane.org>
References: <1478293856-8191-1-git-send-email-kwankhede@nvidia.com>
	<1478293856-8191-11-git-send-email-kwankhede@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kevin.tian@intel.com, cjia@nvidia.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
	jike.song@intel.com, alex.williamson@redhat.com,
	kraxel@redhat.com, pbonzini@redhat.com, bjsdjshi@linux.vnet.ibm.com
To: Kirti Wankhede <kwankhede@nvidia.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <1478293856-8191-11-git-send-email-kwankhede@nvidia.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
List-Id: kvm.vger.kernel.org

* Kirti Wankhede <kwankhede@nvidia.com> [2016-11-05 02:40:44 +0530]:

Hi Kirti,

[...]
> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
> index 8d64528dcc22..e511073446a0 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
[...]

> +static int vfio_pfn_account(struct vfio_addr_space *addr_space,
> +			    unsigned long pfn)
> +{
> +	struct vfio_pfn *p;
> +	int ret = 1;
> +
> +	mutex_lock(&addr_space->pfn_list_lock);
> +	p = vfio_find_pfn(addr_space, pfn);
> +	if (p)
> +		ret = 0;
> +	mutex_unlock(&addr_space->pfn_list_lock);
> +	return ret;
> +}
We could save a local variables(@ret) here by:
	return (p ? 0 : 1);

> +
>  struct vwork {
>  	struct mm_struct	*mm;
>  	long			npage;
[...]

-- 
Dong Jia