From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Subject: Re: [PATCH v14 12/22] vfio: Add notifier callback to
 parent's ops structure of mdev
Date: Thu, 17 Nov 2016 10:15:33 +0800
Message-ID: <21113.7681304992$1505294741@news.gmane.org>
References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com>
	<1479329194-10247-13-git-send-email-kwankhede@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kevin.tian@intel.com, cjia@nvidia.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
	jike.song@intel.com, alex.williamson@redhat.com,
	kraxel@redhat.com, pbonzini@redhat.com, bjsdjshi@linux.vnet.ibm.com
To: Kirti Wankhede <kwankhede@nvidia.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <1479329194-10247-13-git-send-email-kwankhede@nvidia.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
List-Id: kvm.vger.kernel.org

* Kirti Wankhede <kwankhede@nvidia.com> [2016-11-17 02:16:24 +0530]:

Hi Kirti,

> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
[...]

> @@ -51,6 +78,11 @@ static void vfio_mdev_release(void *device_data)
>  	if (likely(parent->ops->release))
>  		parent->ops->release(mdev);
> 
> +	if (likely(parent->ops->notifier)) {
> +		if (vfio_unregister_notifier(&mdev->dev, &mdev->nb))
> +			pr_err("Failed to unregister notifier for mdev\n");
For the -ENOTTY case, we should not fail here either.

> +	}
> +
>  	module_put(THIS_MODULE);
>  }
> 
[...]

-- 
Dong Jia