From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [kvm-unit-tests PATCH v2 1/2] report: add lock to report_abort Date: Tue, 22 Nov 2016 15:48:27 +0100 Message-ID: <212737e8-8caa-2001-9b3a-4715380d9b80@redhat.com> References: <1479824506-19690-1-git-send-email-drjones@redhat.com> <1479824506-19690-2-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: rkrcmar@redhat.com To: Andrew Jones , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38658 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932949AbcKVOs3 (ORCPT ); Tue, 22 Nov 2016 09:48:29 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 153168F507 for ; Tue, 22 Nov 2016 14:48:29 +0000 (UTC) In-Reply-To: <1479824506-19690-2-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 22.11.2016 15:21, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > lib/report.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/report.c b/lib/report.c > index 4cd75534f978..2a8b6df1368d 100644 > --- a/lib/report.c > +++ b/lib/report.c > @@ -118,12 +118,14 @@ void report_abort(const char *msg_fmt, ...) > { > va_list va; > > + spin_lock(&lock); > puts("ABORT: "); > puts(prefixes); > va_start(va, msg_fmt); > vprintf(msg_fmt, va); > va_end(va); > puts("\n"); > + spin_unlock(&lock); > report_summary(); > abort(); > } > Reviewed-by: Thomas Huth