From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Reduce the size of the vmcs_field_to_offset_table
Date: Mon, 1 Jan 2018 23:55:44 +0100 [thread overview]
Message-ID: <2221095b-e32c-21f6-6efc-a2437b5364c5@redhat.com> (raw)
In-Reply-To: <20171222200907.97331-1-jmattson@google.com>
On 22/12/2017 21:09, Jim Mattson wrote:
> The vmcs_field_to_offset_table is quite sparse, with its size determined
> by the highest VMCS field encoding (0x6c16 for HOST_RIP). To support multiple
> VMCS12 formats, we will need multiple vmcs_field_to_offset_tables, and
> it would be a shame to replicate this sparse table.
>
> Patches 1 and 2 are no longer necessary for v2, but I'm going to leave them
> in the patch set, because I still think they are worthwhile.
>
> Jim Mattson (3):
> kvm: vmx: Introduce VMCS12_MAX_FIELD_INDEX
> kvm: vmx: Change vmcs_field_type to vmcs_field_width
> kvm: vmx: Reduce size of vmcs_field_to_offset_table
>
> arch/x86/kvm/vmx.c | 86 +++++++++++++++++++++++++++++++-----------------------
> 1 file changed, 49 insertions(+), 37 deletions(-)
>
Looks good, I'll queue it shortly (after I look a bit more into
Wanpeng's report).
Paolo
prev parent reply other threads:[~2018-01-01 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 20:46 [PATCH 0/3] Reduce the size of the vmcs_field_to_offset_table Jim Mattson
2017-12-21 20:46 ` [PATCH 1/3] kvm: vmx: Introduce VMCS12_MAX_FIELD_INDEX Jim Mattson
2017-12-22 20:11 ` [PATCH v2 " Jim Mattson
2018-01-18 16:46 ` David Hildenbrand
2017-12-21 20:46 ` [PATCH 2/3] kvm: vmx: Change vmcs_field_type to vmcs_field_width Jim Mattson
2017-12-22 20:12 ` [PATCH v2 " Jim Mattson
2017-12-21 20:46 ` [PATCH 3/3] kvm: vmx: Reduce size of vmcs_field_to_offset_table Jim Mattson
2017-12-22 16:26 ` Paolo Bonzini
2017-12-22 18:28 ` Jim Mattson
2017-12-22 20:13 ` [PATCH v2 " Jim Mattson
2017-12-22 20:09 ` [PATCH v2 0/3] Reduce the size of the vmcs_field_to_offset_table Jim Mattson
2018-01-01 22:55 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2221095b-e32c-21f6-6efc-a2437b5364c5@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).