From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 0/3] Reduce the size of the vmcs_field_to_offset_table Date: Mon, 1 Jan 2018 23:55:44 +0100 Message-ID: <2221095b-e32c-21f6-6efc-a2437b5364c5@redhat.com> References: <20171221204623.164581-1-jmattson@google.com> <20171222200907.97331-1-jmattson@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Jim Mattson , kvm@vger.kernel.org Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:42836 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752240AbeAAWzs (ORCPT ); Mon, 1 Jan 2018 17:55:48 -0500 Received: by mail-wm0-f65.google.com with SMTP id b141so12084324wme.1 for ; Mon, 01 Jan 2018 14:55:48 -0800 (PST) In-Reply-To: <20171222200907.97331-1-jmattson@google.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 22/12/2017 21:09, Jim Mattson wrote: > The vmcs_field_to_offset_table is quite sparse, with its size determined > by the highest VMCS field encoding (0x6c16 for HOST_RIP). To support multiple > VMCS12 formats, we will need multiple vmcs_field_to_offset_tables, and > it would be a shame to replicate this sparse table. > > Patches 1 and 2 are no longer necessary for v2, but I'm going to leave them > in the patch set, because I still think they are worthwhile. > > Jim Mattson (3): > kvm: vmx: Introduce VMCS12_MAX_FIELD_INDEX > kvm: vmx: Change vmcs_field_type to vmcs_field_width > kvm: vmx: Reduce size of vmcs_field_to_offset_table > > arch/x86/kvm/vmx.c | 86 +++++++++++++++++++++++++++++++----------------------- > 1 file changed, 49 insertions(+), 37 deletions(-) > Looks good, I'll queue it shortly (after I look a bit more into Wanpeng's report). Paolo