From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "seanjc@google.com" <seanjc@google.com>,
"bp@alien8.de" <bp@alien8.de>, "kas@kernel.org" <kas@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>
Subject: Re: [PATCH 0/2] x86/virt/tdx: Minor sparse fixups
Date: Wed, 29 Oct 2025 20:53:52 +0000 [thread overview]
Message-ID: <22422512e68eb6a62b137379ff3f25436d75af56.camel@intel.com> (raw)
In-Reply-To: <20251029194829.F79F929D@davehans-spike.ostc.intel.com>
On Wed, 2025-10-29 at 12:48 -0700, Dave Hansen wrote:
> Sean recently suggested relying on sparse to add type safety in TDX code,
> hoping that the robots would notice and complain. Well, that plan is not
> working out so great. TDX is not even sparse clean today and nobody seems
> to have noticed or cared.
>
> I can see how folks might ignore the 0 vs. NULL complaints. But the
> misplaced __user is actually bad enough it should be fixed no matter
> what.
>
> Might as well fix it all up.
Oof. But my local distro version of sparse spit out a bunch of noise related to
"warning: unreplaced symbol" in "include/asm-generic/bitops/generic-non-
atomic.h". It also did not find these. But checking with the latest sparse build
from source did, and this fixes them.
next prev parent reply other threads:[~2025-10-29 20:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 19:48 [PATCH 0/2] x86/virt/tdx: Minor sparse fixups Dave Hansen
2025-10-29 19:48 ` [PATCH 1/2] x86/virt/tdx: Remove __user annotation from kernel pointer Dave Hansen
2025-10-29 21:06 ` Edgecombe, Rick P
2025-10-29 21:13 ` Dave Hansen
2025-10-29 23:00 ` Sean Christopherson
2025-10-29 23:34 ` Dave Hansen
2025-10-30 0:04 ` Sean Christopherson
2025-10-29 19:48 ` [PATCH 2/2] x86/virt/tdx: Fix sparse warnings from using 0 for NULL Dave Hansen
2025-10-29 21:09 ` Edgecombe, Rick P
2025-10-29 20:53 ` Edgecombe, Rick P [this message]
2025-10-29 21:10 ` [PATCH 0/2] x86/virt/tdx: Minor sparse fixups Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22422512e68eb6a62b137379ff3f25436d75af56.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox