From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kirti Wankhede Subject: Re: [PATCH 3/8] vfio/mdev: Removed unused kref Date: Tue, 26 Mar 2019 00:11:01 +0530 Message-ID: <235e0fbf-0ed7-211e-64fa-08a173db45c0@nvidia.com> References: <1553296835-37522-1-git-send-email-parav@mellanox.com> <1553296835-37522-4-git-send-email-parav@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: Parav Pandit , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "alex.williamson@redhat.com" Return-path: In-Reply-To: <1553296835-37522-4-git-send-email-parav@mellanox.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 3/23/2019 4:50 AM, Parav Pandit wrote: > Remove unused kref from the mdev_device structure. > > Fixes: 7b96953bc640 ("vfio: Mediated device Core driver") > Signed-off-by: Parav Pandit > --- > drivers/vfio/mdev/mdev_core.c | 1 - > drivers/vfio/mdev/mdev_private.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 4f213e4d..3d91f62 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -311,7 +311,6 @@ int mdev_device_create(struct kobject *kobj, struct device *dev, uuid_le uuid) > mutex_unlock(&mdev_list_lock); > > mdev->parent = parent; > - kref_init(&mdev->ref); > > mdev->dev.parent = dev; > mdev->dev.bus = &mdev_bus_type; > diff --git a/drivers/vfio/mdev/mdev_private.h b/drivers/vfio/mdev/mdev_private.h > index b5819b7..84b2b6c 100644 > --- a/drivers/vfio/mdev/mdev_private.h > +++ b/drivers/vfio/mdev/mdev_private.h > @@ -30,7 +30,6 @@ struct mdev_device { > struct mdev_parent *parent; > uuid_le uuid; > void *driver_data; > - struct kref ref; > struct list_head next; > struct kobject *type_kobj; > bool active; > Yes, this should be removed. Reviewed By: Kirti Wankhede Thanks, Kirti