public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nico Boehr <nrb@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org
Cc: imbrenda@linux.ibm.com, thuth@redhat.com, david@redhat.com,
	farman@linux.ibm.com
Subject: Re: [PATCH 2/2] s390x: add test for SIGP STORE_ADTL_STATUS order
Date: Wed, 30 Mar 2022 14:46:37 +0200	[thread overview]
Message-ID: <2633aab12d0ec64bfc353013a3fd6b428070076d.camel@linux.ibm.com> (raw)
In-Reply-To: <7cca996a-454d-7287-1d91-c7f5908b0f15@linux.ibm.com>

On Tue, 2022-03-29 at 13:39 +0200, Janosch Frank wrote:
> > I think that won't work because that function might clean its float
> > registers in the epilogue and hence destroy the contents. Except if
> > you
> > have an idea on how to avoid that?

I missed that this is a theoretical problem because the function will
be inlined anyway.

> About that:
> 
> Well, who guarantees you that the compiler won't change a fpr (and 
> thereby the overlapped vrs) between the vlms here and your infinite
> loop 
> at the end of the function? :-) gcc uses fprs and acrs in the most 
> interesting places and I've just been hit by that again a few hours
> ago.
> 
> I.e. to be safe we'll need to implement the next few lines in
> assembly 
> as well, no?

I guess so. I will go ahead and reimplement everything in assembly?

      reply	other threads:[~2022-03-30 12:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28  9:30 [PATCH 0/2] s390x: Add tests for SIGP store adtl status Nico Boehr
2022-03-28  9:30 ` [PATCH 1/2] s390x: gs: move to new header file Nico Boehr
2022-03-28  9:30 ` [PATCH 2/2] s390x: add test for SIGP STORE_ADTL_STATUS order Nico Boehr
2022-03-28 11:54   ` Janosch Frank
2022-03-28 15:12     ` Nico Boehr
2022-03-29 11:39       ` Janosch Frank
2022-03-30 12:46         ` Nico Boehr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2633aab12d0ec64bfc353013a3fd6b428070076d.camel@linux.ibm.com \
    --to=nrb@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox