From: Marc Zyngier <marc.zyngier@arm.com>
To: Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
cdall@kernel.org, peter.maydell@linaro.org
Cc: andre.przywara@arm.com, drjones@redhat.com, wei@redhat.com
Subject: Re: [RFC v2 01/12] KVM: arm/arm64: Set dist->spis to NULL after kfree
Date: Tue, 27 Mar 2018 18:10:46 +0100 [thread overview]
Message-ID: <26bb42a7-d946-e52c-68e6-eaeaae325983@arm.com> (raw)
In-Reply-To: <1522159456-10419-2-git-send-email-eric.auger@redhat.com>
On 27/03/18 15:04, Eric Auger wrote:
> in case kvm_vgic_map_resources() fails, typically if the vgic
> distributor is not defined, __kvm_vgic_destroy will be called
> several times. Indeed kvm_vgic_map_resources() is called on
> first vcpu run. As a result dist->spis is freeed more than once
> and on the second time it causes a "kernel BUG at mm/slub.c:3912!"
>
> Set dist->spis to NULL to avoid the crash.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
Fixes: ad275b8bb1e6 ("KVM: arm/arm64: vgic-new: vgic_init: implement
vgic_init")
Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-03-27 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 14:04 [RFC v2 00/12] KVM: arm/arm64: Allow multiple GICv3 redistributor regions Eric Auger
2018-03-27 14:04 ` [RFC v2 01/12] KVM: arm/arm64: Set dist->spis to NULL after kfree Eric Auger
2018-03-27 17:10 ` Marc Zyngier [this message]
2018-03-28 6:41 ` Auger Eric
2018-03-27 14:04 ` [RFC v2 02/12] KVM: arm/arm64: Document KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger
2018-04-09 21:38 ` Christoffer Dall
2018-04-12 15:51 ` Auger Eric
2018-03-27 14:04 ` [RFC v2 03/12] KVM: arm/arm64: Replace the single rdist region by a list Eric Auger
2018-03-27 14:04 ` [RFC v2 04/12] KVM: arm/arm64: Helper to locate free rdist index Eric Auger
2018-03-27 14:04 ` [RFC v2 05/12] KVM: arm/arm64: Revisit Redistributor TYPER last bit computation Eric Auger
2018-03-27 14:04 ` [RFC v2 06/12] KVM: arm/arm64: Helper to register a new redistributor region Eric Auger
2018-03-27 14:04 ` [RFC v2 07/12] KVM: arm/arm64: Adapt vgic_v3_check_base to multiple rdist regions Eric Auger
2018-03-27 14:04 ` [RFC v2 08/12] KVM: arm/arm64: Check vcpu redist base before registering an iodev Eric Auger
2018-03-27 14:04 ` [RFC v2 09/12] KVM: arm/arm64: Check all vcpu redistributors are set on map_resources Eric Auger
2018-03-27 14:04 ` [RFC v2 10/12] KVM: arm/arm64: Add KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger
2018-03-27 14:04 ` [RFC v2 11/12] KVM: arm/arm64: Implement KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger
2018-03-28 18:55 ` Peter Maydell
2018-03-28 20:19 ` Auger Eric
2018-03-27 14:04 ` [RFC v2 12/12] KVM: arm/arm64: Bump VGIC_V3_MAX_CPUS to 512 Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26bb42a7-d946-e52c-68e6-eaeaae325983@arm.com \
--to=marc.zyngier@arm.com \
--cc=andre.przywara@arm.com \
--cc=cdall@kernel.org \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.maydell@linaro.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox