From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>,
frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v1 4/4] s390x: add a test for SIE without MSO/MSL
Date: Fri, 14 Apr 2023 12:24:57 +0200 [thread overview]
Message-ID: <27714b8fdeb24b44b07bdd08056458345ff0c61b.camel@linux.ibm.com> (raw)
In-Reply-To: <168146700513.42330.5991739646507426126@t14-nrb>
On Fri, 2023-04-14 at 12:10 +0200, Nico Boehr wrote:
> Quoting Nina Schoetterl-Glausch (2023-04-13 18:33:50)
> [...]
> > With a small linker script change the snippet could know it's own length.
> > Then you could map just the required number of pages and don't need to keep those numbers in sync.
>
> Maybe it's because my knowledge about linker scripts is really limited or I
> don't get it, but I fail to see the advantage of the additional complexity.
>
> My assumption would be that the number of pages mapped for the guest memory will
> never really change. Keeping a define in sync seems more pragmatic than going
> through linker script magic.
I think just
+ . = ALIGN(4K);
+ esnippet = .;
/* End data */
at the bottom of the snippet linker script would suffice.
Then you could use esnippet as an extern symbol in the C code.
But yeah, might not be worth it unless it would help with other snippets too.
prev parent reply other threads:[~2023-04-14 10:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 8:21 [kvm-unit-tests PATCH v1 0/4] s390x: Add support for running guests without MSO/MSL Nico Boehr
2023-03-27 8:21 ` [kvm-unit-tests PATCH v1 1/4] s390x: sie: switch to home space mode before entering SIE Nico Boehr
2023-03-28 14:13 ` Janosch Frank
2023-03-29 12:50 ` Nico Boehr
2023-03-29 13:00 ` Claudio Imbrenda
2023-03-29 13:42 ` Janosch Frank
2023-03-29 14:58 ` Nico Boehr
2023-03-27 8:21 ` [kvm-unit-tests PATCH v1 2/4] s390x: lib: don't forward PSW when handling exception in SIE Nico Boehr
2023-03-27 8:21 ` [kvm-unit-tests PATCH v1 3/4] s390x: lib: sie: don't reenter SIE on pgm int Nico Boehr
2023-03-28 13:42 ` Janosch Frank
2023-03-28 14:16 ` Nico Boehr
2023-03-28 17:01 ` Claudio Imbrenda
2023-03-29 12:51 ` Nico Boehr
2023-03-27 8:21 ` [kvm-unit-tests PATCH v1 4/4] s390x: add a test for SIE without MSO/MSL Nico Boehr
2023-04-05 19:55 ` Nina Schoetterl-Glausch
2023-04-06 8:01 ` Janosch Frank
2023-04-13 9:43 ` Nico Boehr
2023-04-13 16:33 ` Nina Schoetterl-Glausch
2023-04-14 10:10 ` Nico Boehr
2023-04-14 10:24 ` Nina Schoetterl-Glausch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27714b8fdeb24b44b07bdd08056458345ff0c61b.camel@linux.ibm.com \
--to=nsg@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox