Re: [PATCH v7 01/17] KVM: s390: pv: leak the topmost page table when destroy fails

Claudio Imbrenda
2022-02-07T15:01:09Z

On Mon, 7 Feb 2022 15:33:15 +0100
Heiko Carstens <hca@linux.ibm.com> wrote:

> > > + asce = (gmap->asce & ~PAGE_MASK) | __pa(table);
> >
> > Please add a comment:
> > Set the new table origin while preserving ASCE control bits like table type
> > and length.
>
> And while touching this anyway, please make use of _ASCE_ORIGIN
> instead of PAGE_MASK.

will fix