From: Paolo Bonzini <pbonzini@redhat.com>
To: Roman Kagan <rkagan@virtuozzo.com>,
Yunhong Jiang <yunhong.jiang@linux.intel.com>,
kvm@vger.kernel.org, mtosatti@redhat.com, rkrcmar@redhat.com,
kernellwp@gmail.com
Subject: Re: [RFC PATCH V2 2/4] Utilize the vmx preemption timer
Date: Tue, 14 Jun 2016 15:41:07 +0200 [thread overview]
Message-ID: <27f8a049-4e8f-27fd-8fe2-6121f6218f25@redhat.com> (raw)
In-Reply-To: <20160614125537.b3qlcjytjb64ezht@rkaganb.sw.ru>
On 14/06/2016 15:23, Roman Kagan wrote:
>> >
>> > +static int cpu_preemption_timer_multi;
>> > +static bool __read_mostly enable_hv_timer;
>> > +module_param_named(enable_hv_timer, enable_hv_timer, bool, S_IRUGO);
>> > +
> Non-techincal issue: I think the naming for the parameter is
> unfortunate, as it looks similar to a number of CPU properties in QEMU
> that start with "hv-", which are all related to MS Hyper-V compatibility
> features.
Non-technical but important. Let's change it to preemption_timer (and
the variable to enable_preemption_timer).
The code can keep the "hv_timer" moniker though.
Paolo
next prev parent reply other threads:[~2016-06-14 13:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 22:27 [RFC PATCH V2 0/4] Utilizing VMX preemption for timer virtualization Yunhong Jiang
2016-05-24 22:27 ` [RFC PATCH V2 1/4] Add the kvm sched_out hook Yunhong Jiang
2016-05-24 22:27 ` [RFC PATCH V2 2/4] Utilize the vmx preemption timer Yunhong Jiang
2016-06-14 13:23 ` Roman Kagan
2016-06-14 13:41 ` Paolo Bonzini [this message]
2016-06-14 16:46 ` yunhong jiang
2016-06-14 21:56 ` Paolo Bonzini
2016-06-15 18:03 ` yunhong jiang
2016-06-14 16:46 ` yunhong jiang
2016-05-24 22:27 ` [RFC PATCH V2 3/4] Separate the start_sw_tscdeadline Yunhong Jiang
2016-05-24 22:27 ` [RFC PATCH V2 4/4] Utilize the vmx preemption timer for tsc deadline timer Yunhong Jiang
2016-05-24 23:11 ` David Matlack
2016-05-24 23:35 ` yunhong jiang
2016-05-25 11:58 ` Paolo Bonzini
2016-05-25 22:53 ` yunhong jiang
2016-05-26 7:20 ` Paolo Bonzini
2016-05-25 10:40 ` Paolo Bonzini
2016-05-25 13:38 ` Radim Krčmář
2016-05-25 11:52 ` Paolo Bonzini
2016-05-25 22:44 ` yunhong jiang
2016-05-26 14:05 ` Alan Jenkins
2016-05-26 15:32 ` Paolo Bonzini
2016-06-04 0:24 ` yunhong jiang
2016-06-06 13:49 ` Paolo Bonzini
2016-06-06 18:21 ` yunhong jiang
2016-05-25 13:27 ` Radim Krčmář
2016-05-25 13:51 ` Paolo Bonzini
2016-05-25 14:31 ` Radim Krčmář
2016-05-25 23:13 ` yunhong jiang
2016-06-14 11:34 ` Paolo Bonzini
2016-05-25 13:45 ` Radim Krčmář
2016-05-25 22:57 ` yunhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27f8a049-4e8f-27fd-8fe2-6121f6218f25@redhat.com \
--to=pbonzini@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=rkagan@virtuozzo.com \
--cc=rkrcmar@redhat.com \
--cc=yunhong.jiang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).