From: Paolo Bonzini <pbonzini@redhat.com>
To: Will Deacon <will@kernel.org>
Cc: kvm@vger.kernel.org, kernellwp@gmail.com,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"# 5 . 2 . y" <stable@kernel.org>
Subject: Re: [PATCH] kvm: Ensure writes to the coalesced MMIO ring are within bounds
Date: Wed, 18 Sep 2019 16:11:34 +0200 [thread overview]
Message-ID: <281758dd-e400-f99c-b2e2-d32bca9f371e@redhat.com> (raw)
In-Reply-To: <20190918135932.aitmvncwujmjnwyr@willie-the-truck>
On 18/09/19 15:59, Will Deacon wrote:
> Okey doke, as long as it gets fixed! My minor concerns with the error-checking
> variant are:
>
> * Whether or not you need a READ_ONCE to prevent the compiler potentially
> reloading 'ring->last' after validation
Yes, it certainly needs READ_ONCE. I had already added it locally, indeed.
> * Whether or not this could be part of a spectre-v1 gadget
I think not, the spectrev1 gadget require a load that is indexed from
the contents of ring->coalesced_mmio[insert], but there's none.
Paolo
> so, given that I don't think the malicious host deserves an error code if it
> starts writing the 'last' index, I went with the "obviously safe" version.
> But up to you.
>
> Will
>
prev parent reply other threads:[~2019-09-18 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 13:15 [PATCH] kvm: Ensure writes to the coalesced MMIO ring are within bounds Will Deacon
2019-09-18 13:30 ` Greg Kroah-Hartman
2019-09-18 13:41 ` Paolo Bonzini
2019-09-18 13:59 ` Will Deacon
2019-09-18 14:11 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=281758dd-e400-f99c-b2e2-d32bca9f371e@redhat.com \
--to=pbonzini@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox