From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 2/5] KVM: MMU: check guest CR3 reserved bits based on
 its physical address width.
Date: Thu, 17 Aug 2017 14:31:11 +0200
Message-ID: <28276aa5-76e5-1826-5b1f-e18a62cd903d@redhat.com>
References: <1502999558-2517-1-git-send-email-yu.c.zhang@linux.intel.com>
 <1502999558-2517-3-git-send-email-yu.c.zhang@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, rkrcmar@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        xiaoguangrong@tencent.com, joro@8bytes.org
To: Yu Zhang <yu.c.zhang@linux.intel.com>, kvm@vger.kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1502999558-2517-3-git-send-email-yu.c.zhang@linux.intel.com>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 17/08/2017 21:52, Yu Zhang wrote:
> +		if (efer & EFER_LMA) {
> +			u64 maxphyaddr;
> +			u32 eax = 0x80000008;
> +
> +			if (ctxt->ops->get_cpuid(ctxt, &eax, NULL, NULL, NULL,
> +						 NO_CHECK_LIMIT)) {
> +				maxphyaddr = eax & 0xff;
> +				rsvd = rsvd_bits(maxphyaddr, 62);
> +			}

You should use 36 here if ctxt->ops->get_cpuid returns false, for
consistency with cpuid_query_maxphyaddr.

Paolo