From: Tao Xu <tao3.xu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
rkrcmar@redhat.com, corbet@lwn.net, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
sean.j.christopherson@intel.com
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, jingqi.liu@intel.com
Subject: Re: [PATCH v2 2/3] KVM: vmx: Emulate MSR IA32_UMWAIT_CONTROL
Date: Wed, 29 May 2019 09:38:13 +0800 [thread overview]
Message-ID: <2922ac60-a22e-e22c-363a-04f3a2bb6838@intel.com> (raw)
In-Reply-To: <c9f5050a-6144-adbc-25ef-8a7543176ac6@redhat.com>
On 29/05/2019 09:29, Paolo Bonzini wrote:
> On 24/05/19 09:56, Tao Xu wrote:
>> +
>> + if (rdmsrl_safe(MSR_IA32_UMWAIT_CONTROL, &host_umwait_control))
>> + return;
>> +
>
> Does the host value ever change? If not, this can perhaps be read once
> when kvm_intel is loaded. And if it changes often, it should be
> shadowed into a percpu variable.
>
> Paolo
>
Yes, the host value may change, we contact the host patch author Fenghua
to add the shadow in host when the host msr value change. And we will
improve this in the next version of patch.
next prev parent reply other threads:[~2019-05-29 1:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 7:56 [PATCH v2 0/3] KVM: x86: Enable user wait instructions Tao Xu
2019-05-24 7:56 ` [PATCH v2 1/3] KVM: x86: add support for " Tao Xu
2019-05-27 10:30 ` Peter Zijlstra
2019-05-28 5:11 ` Tao Xu
2019-05-28 6:11 ` Wanpeng Li
2019-05-28 7:19 ` Tao Xu
2019-05-29 1:26 ` Paolo Bonzini
2019-05-29 1:25 ` Paolo Bonzini
2019-05-29 1:24 ` Paolo Bonzini
2019-05-29 2:05 ` Tao Xu
2019-05-29 2:38 ` Paolo Bonzini
2019-05-29 3:12 ` Tao Xu
2019-05-24 7:56 ` [PATCH v2 2/3] KVM: vmx: Emulate MSR IA32_UMWAIT_CONTROL Tao Xu
2019-05-29 1:29 ` Paolo Bonzini
2019-05-29 1:38 ` Tao Xu [this message]
2019-05-24 7:56 ` [PATCH v2 3/3] KVM: vmx: handle vm-exit for UMWAIT and TPAUSE Tao Xu
2019-05-29 1:28 ` Paolo Bonzini
2019-05-29 2:25 ` Tao Xu
2019-05-29 2:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2922ac60-a22e-e22c-363a-04f3a2bb6838@intel.com \
--to=tao3.xu@intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=hpa@zytor.com \
--cc=jingqi.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox