From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support
Date: Fri, 2 Sep 2016 23:48:38 +0200
Message-ID: <2a195ed1-f6aa-ffab-3f5c-4121de264d05@redhat.com>
References: <1472097235-6332-1-git-send-email-kwankhede@nvidia.com>
 <20160830101638.49df467d@t450s.home>
 <AADFC41AFE54684AB9EE6CBC0274A5D18DEBD970@SHSMSX101.ccr.corp.intel.com>
 <78fedd65-6d62-e849-ff3b-d5105b2da816@redhat.com>
 <20160901105948.62f750aa@t450s.home>
 <b4f7b36a-7bca-ef04-e6f5-8b817700250c@redhat.com>
 <98bbdbbf-c388-9120-3306-64f0cfb820a7@nvidia.com>
 <8682faeb-0331-f014-c13e-03c20f3f2bdf@redhat.com>
 <a5476012-0d17-d7bc-b63e-e361b5d7d34e@nvidia.com>
 <f3da1991-f8aa-e330-4b80-509e4f13896b@redhat.com>
 <fde200db-85d2-d979-1f8c-85dada4d6efe@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "Song, Jike" <jike.song@intel.com>,
        "cjia@nvidia.com" <cjia@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "libvir-list@redhat.com" <libvir-list@redhat.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
        "kraxel@redhat.com" <kraxel@redhat.com>,
        Laine Stump <laine@redhat.com>,
        "bjsdjshi@linux.vnet.ibm.com" <bjsdjshi@linux.vnet.ibm.com>
To: Kirti Wankhede <kwankhede@nvidia.com>,
        Michal Privoznik <mprivozn@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f67.google.com ([74.125.82.67]:35772 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752669AbcIBVsm (ORCPT <rfc822;kvm@vger.kernel.org>);
        Fri, 2 Sep 2016 17:48:42 -0400
Received: by mail-wm0-f67.google.com with SMTP id c133so4449342wmd.2
        for <kvm@vger.kernel.org>; Fri, 02 Sep 2016 14:48:42 -0700 (PDT)
In-Reply-To: <fde200db-85d2-d979-1f8c-85dada4d6efe@nvidia.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 02/09/2016 20:33, Kirti Wankhede wrote:
> <Alex> We could even do:
>> >
>> > echo $UUID1:$GROUPA > create
>> >
>> > where $GROUPA is the group ID of a previously created mdev device into
>> > which $UUID1 is to be created and added to the same group.
> </Alex>

>>From the point of view of libvirt, I think I prefer Alex's idea.
<group> could be an additional element in the nodedev-create XML:

    <device>
      <name>my-vgpu</name>
      <parent>pci_0000_86_00_0</parent>
      <capability type='mdev'>
        <type id='11'/>
        <uuid>0695d332-7831-493f-9e71-1c85c8911a08</uuid>
        <group>group1</group>
      </capability>
    </device>

(should group also be a UUID?)

Since John brought up the topic of minimal XML, in this case it will be
like this:

    <device>
      <name>my-vgpu</name>
      <parent>pci_0000_86_00_0</parent>
      <capability type='mdev'>
        <type id='11'/>
      </capability>
    </device>

The uuid will be autogenerated by libvirt and if there's no <group> (as
is common for VMs with only 1 vGPU) it will be a single-device group.

Thanks,

Paolo