From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers Date: Thu, 3 Aug 2017 13:53:06 +0200 Message-ID: <2bc44983-64ef-38ff-2a29-fa6c61247ccc@redhat.com> References: <20170802204147.3586-1-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Paolo Bonzini To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <20170802204147.3586-1-rkrcmar@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 02.08.2017 22:41, Radim Krčmář wrote: > This series does the generalization that we've spoken about recently > Might be a good time to change the function names as well. > > > Radim Krčmář (2): > KVM: x86: generalize guest_cpuid_has_ helpers > KVM: x86: use general helpers for some cpuid manipulation > > arch/x86/kvm/cpuid.h | 205 ++++++++++++++++++--------------------------------- > arch/x86/kvm/mmu.c | 7 +- > arch/x86/kvm/mtrr.c | 2 +- > arch/x86/kvm/svm.c | 7 +- > arch/x86/kvm/vmx.c | 33 ++++----- > arch/x86/kvm/x86.c | 52 ++++++------- > 6 files changed, 116 insertions(+), 190 deletions(-) > These numbers speak for themselves. I really like this cleanup! Had a quick look over the patches, nothing jumped at me. -- Thanks, David