From: Xiao Guangrong <guangrong.xiao@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Peter Feiner" <pfeiner@google.com>,
"David Matlack" <dmatlack@google.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Xiao Guangrong" <xiaoguangrong@tencent.com>,
"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH 1/2] KVM: nVMX: fix EPT permissions as reported in exit qualification
Date: Fri, 12 May 2017 13:13:07 +0800 [thread overview]
Message-ID: <2c89d7f5-b806-4bd8-e4cb-60e946ee7822@gmail.com> (raw)
In-Reply-To: <482f1c96-ce6a-8b77-ce18-ec5f19cde800@gmail.com>
On 05/12/2017 11:59 AM, Xiao Guangrong wrote:
error:
>> @@ -452,7 +459,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
>> */
>> if (!(errcode & PFERR_RSVD_MASK)) {
>> vcpu->arch.exit_qualification &= 0x187;
>> - vcpu->arch.exit_qualification |= ((pt_access & pte) & 0x7) << 3;
> ^ here, the original code
> is buggy as pt_access and pte have different bit order, fortunately, this patch fixes it
> too. :)
>
It's exactly what this patch aims at, do not know what i was thinking when
wrote these down. :(
next prev parent reply other threads:[~2017-05-12 5:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 11:23 [PATCH 0/2] KVM: nVMX: nested EPT fixes Paolo Bonzini
2017-05-11 11:23 ` [PATCH 1/2] KVM: nVMX: fix EPT permissions as reported in exit qualification Paolo Bonzini
2017-05-12 3:59 ` Xiao Guangrong
2017-05-12 5:13 ` Xiao Guangrong [this message]
2017-05-11 11:23 ` [PATCH 2/2] KVM: nVMX: fix nEPT handling of guest page table accesses Paolo Bonzini
2017-05-12 7:38 ` Xiao Guangrong
2017-05-12 8:39 ` Paolo Bonzini
2017-05-16 14:03 ` [PATCH 0/2] KVM: nVMX: nested EPT fixes Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c89d7f5-b806-4bd8-e4cb-60e946ee7822@gmail.com \
--to=guangrong.xiao@gmail.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
--cc=xiaoguangrong@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox