From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@gmail.com>
Subject: Re: [PATCH 1/2] KVM: nVMX: fix EPT permissions as reported in exit
 qualification
Date: Fri, 12 May 2017 13:13:07 +0800
Message-ID: <2c89d7f5-b806-4bd8-e4cb-60e946ee7822@gmail.com>
References: <1494501810-11822-1-git-send-email-pbonzini@redhat.com>
 <1494501810-11822-2-git-send-email-pbonzini@redhat.com>
 <482f1c96-ce6a-8b77-ce18-ec5f19cde800@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Peter Feiner <pfeiner@google.com>,
        David Matlack <dmatlack@google.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Xiao Guangrong <xiaoguangrong@tencent.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <482f1c96-ce6a-8b77-ce18-ec5f19cde800@gmail.com>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 05/12/2017 11:59 AM, Xiao Guangrong wrote:
error:
>> @@ -452,7 +459,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
>>        */
>>       if (!(errcode & PFERR_RSVD_MASK)) {
>>           vcpu->arch.exit_qualification &= 0x187;
>> -        vcpu->arch.exit_qualification |= ((pt_access & pte) & 0x7) << 3;
>                                                                  ^ here, the original code
> is buggy as pt_access and pte have different bit order, fortunately, this patch fixes it
> too. :)
> 

It's exactly what this patch aims at, do not know what i was thinking when
wrote these down. :(