From: "Nutty Liu" <liujingqi@lanxincomputing.com>
To: "Andrew Jones" <andrew.jones@linux.dev>, <kvm@vger.kernel.org>,
<kvmarm@lists.linux.dev>, <kvm-riscv@lists.infradead.org>
Cc: <alexandru.elisei@arm.com>, <cleger@rivosinc.com>,
<jesse@rivosinc.com>, <jamestiotio@gmail.com>,
"Atish Patra" <atishp@rivosinc.com>
Subject: Re: [kvm-unit-tests PATCH 1/2] arm/arm64: Ensure proper host arch with kvmtool
Date: Tue, 8 Jul 2025 11:41:18 +0800 [thread overview]
Message-ID: <2ccbb58b-1993-450e-b9c5-4b7fcb9c80a2@lanxincomputing.com> (raw)
In-Reply-To: <20250704151254.100351-5-andrew.jones@linux.dev>
On 7/4/2025 11:12 PM, Andrew Jones wrote:
> When running on non-arm (e.g. an x86 machine) if the framework is
> configured to use kvmtool then, unlike with QEMU, it can't work.
>
> Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
Reviewed-by: Nutty Liu <liujingqi@lanxincomputing.com>
Thanks,
Nutty
> ---
> arm/run | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arm/run b/arm/run
> index 9ee795ae424c..858333fce465 100755
> --- a/arm/run
> +++ b/arm/run
> @@ -97,6 +97,11 @@ function arch_run_kvmtool()
> {
> local command
>
> + if [ "$HOST" != "arm" ] && [ "$HOST" != "aarch64" ]; then
> + echo "kvmtool requires KVM but the host ('$HOST') is not arm" >&2
> + exit 2
> + fi
> +
> kvmtool=$(search_kvmtool_binary) ||
> exit $?
next prev parent reply other threads:[~2025-07-08 3:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 15:12 [kvm-unit-tests PATCH 0/2] riscv: Add kvmtool support Andrew Jones
2025-07-04 15:12 ` [kvm-unit-tests PATCH 1/2] arm/arm64: Ensure proper host arch with kvmtool Andrew Jones
2025-07-07 15:10 ` Jesse Taube
2025-07-08 3:41 ` Nutty Liu [this message]
2025-07-04 15:12 ` [kvm-unit-tests PATCH 2/2] riscv: Add kvmtool support Andrew Jones
2025-07-07 15:28 ` Jesse Taube
2025-07-07 17:44 ` Andrew Jones
2025-07-08 3:43 ` Nutty Liu
2025-07-08 9:00 ` [kvm-unit-tests PATCH 0/2] " Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ccbb58b-1993-450e-b9c5-4b7fcb9c80a2@lanxincomputing.com \
--to=liujingqi@lanxincomputing.com \
--cc=alexandru.elisei@arm.com \
--cc=andrew.jones@linux.dev \
--cc=atishp@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=jamestiotio@gmail.com \
--cc=jesse@rivosinc.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).