public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com, hca@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH] lib: s390x: css: Name inline assembly arguments and clean them up
Date: Wed, 5 Feb 2025 09:17:46 +0100	[thread overview]
Message-ID: <2d183675-09f8-4ab3-bc4d-67f203f0487c@linux.ibm.com> (raw)
In-Reply-To: <D7JOEGIKCINO.1NX73MSQGVGYZ@linux.ibm.com>

On 2/4/25 1:55 PM, Nico Boehr wrote:
> On Tue Feb 4, 2025 at 10:51 AM CET, Janosch Frank wrote:
>> @@ -215,9 +215,9 @@ static inline int xsch(unsigned long schid)
>>   
>>   	asm volatile(
>>   		"	xsch\n"
>> -		"	ipm	%0\n"
>> -		"	srl	%0,28"
>> -		: "=d" (cc)
>> +		"	ipm	%[cc]\n"
>> +		"	srl	%cc,28"
> 
> Should this be:
> 		"	srl	%[cc],28"
> instead?
> 
> With that fixed (if it needs fixing):
> 
> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
> 

Thanks!
Fixed and applied.


  reply	other threads:[~2025-02-05  8:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04  9:51 [kvm-unit-tests PATCH] lib: s390x: css: Name inline assembly arguments and clean them up Janosch Frank
2025-02-04 12:55 ` Nico Boehr
2025-02-05  8:17   ` Janosch Frank [this message]
2025-02-05 10:25 ` Claudio Imbrenda
2025-02-05 12:08   ` Janosch Frank
2025-02-06 10:36   ` Janosch Frank
2025-02-06 12:03     ` Claudio Imbrenda
2025-02-06 12:42     ` Nico Boehr
2025-02-06 17:22 ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d183675-09f8-4ab3-bc4d-67f203f0487c@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox