Re: [PATCH v5 02/12] iommufd: Refactor __fault_domain_replace_dev() to be a wrapper of iommu_replace_group_handle()

Baolu Lu
2024-11-05T05:07:10Z

On 11/4/24 21:25, Yi Liu wrote:
> There is a wrapper of iommu_attach_group_handle(), so making a wrapper for
> iommu_replace_group_handle() for further code refactor. No functional change
> intended.

This patch is not a simple, non-functional refactoring. It allocates
attach_handle for all devices in domain attach/replace interfaces,
regardless of whether the domain is iopf-capable. Therefore, the commit
message should be rephrased to accurately reflect the patch's purpose
and rationale.

--
baolu