Re: [PATCH v5 03/12] iommufd: Move the iommufd_handle helpers to device.c

Jason Gunthorpe
2024-11-05T15:18:40Z

On Tue, Nov 05, 2024 at 04:01:24PM +0800, Yi Liu wrote:

> > By placing the helper near its callers and perhaps adding comments
> > explaining this limitation, we can improve maintainability and prevent
> > misuse in the future.
>
> with this comment, it seems better to put it in the header file. There are
> two files that has referred this helper. the fault.c and iommufd_private.h.

Put kdoc comments at the function body in the .c file please

Jason