From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quan Xu Subject: Re: [PATCH] KVM: VMX: fix page leak in hardware_setup() Date: Thu, 7 Dec 2017 11:57:03 +0800 Message-ID: <2d513987-80d5-8075-404c-221f4f288ae7@gmail.com> References: <20171201175756.16841-1-jmattson@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Jim Mattson , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , kvm@vger.kernel.org Return-path: Received: from mail-oi0-f65.google.com ([209.85.218.65]:41688 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbdLGD5I (ORCPT ); Wed, 6 Dec 2017 22:57:08 -0500 Received: by mail-oi0-f65.google.com with SMTP id t78so4067521oie.8 for ; Wed, 06 Dec 2017 19:57:08 -0800 (PST) In-Reply-To: <20171201175756.16841-1-jmattson@google.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 2017/12/02 01:57, Jim Mattson wrote: > vmx_io_bitmap_b should not be allocated twice. > > Fixes: 23611332938d ("KVM: VMX: refactor setup of global page-sized bitmaps") > Signed-off-by: Jim Mattson > --- > arch/x86/kvm/vmx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 4704aaf6d19e..5fb5c4aff1cf 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -6751,7 +6751,6 @@ static __init int hardware_setup(void) > goto out; > } > > - vmx_io_bitmap_b = (unsigned long *)__get_free_page(GFP_KERNEL); > memset(vmx_vmread_bitmap, 0xff, PAGE_SIZE); > memset(vmx_vmwrite_bitmap, 0xff, PAGE_SIZE); > Reviewed-by: Quan Xu