From: Paolo Bonzini <pbonzini@redhat.com>
To: Jason Wang <jasowang@redhat.com>,
Elena Afanasova <eafanasova@gmail.com>,
kvm@vger.kernel.org
Cc: stefanha@redhat.com, jag.raman@oracle.com,
elena.ufimtseva@oracle.com, mst@redhat.com, cohuck@redhat.com,
john.levon@nutanix.com
Subject: Re: [RFC v3 4/5] KVM: add ioregionfd context
Date: Tue, 9 Mar 2021 09:01:22 +0100 [thread overview]
Message-ID: <2e7dfb1c-fe13-4e6d-ae65-133116866c2a@redhat.com> (raw)
In-Reply-To: <2ee8cb35-3043-fc06-9973-c8bb33a90d40@redhat.com>
On 09/03/21 08:54, Jason Wang wrote:
>>
>> + return;
>> +
>> + spin_lock(&ctx->wq.lock);
>> + wait_event_interruptible_exclusive_locked(ctx->wq, !ctx->busy);
>
>
> Any reason that a simple mutex_lock_interruptible() can't work here?
Or alternatively why can't the callers just take the spinlock.
Paolo
>
> Thanks
>
>
>> + ctx->busy = true;
>> + spin_unlock(&ctx->wq.lock);
next prev parent reply other threads:[~2021-03-09 8:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 12:04 [RFC v3 0/5] Introduce MMIO/PIO dispatch file descriptors (ioregionfd) Elena Afanasova
2021-02-21 12:04 ` [RFC v3 1/5] KVM: add initial support for KVM_SET_IOREGION Elena Afanasova
2021-02-24 10:06 ` Stefan Hajnoczi
2021-03-05 13:09 ` Cornelia Huck
2021-03-09 5:26 ` Jason Wang
2021-03-22 9:57 ` Stefan Hajnoczi
2021-02-21 12:04 ` [RFC v3 2/5] KVM: x86: add support for ioregionfd signal handling Elena Afanasova
2021-02-24 10:42 ` Stefan Hajnoczi
2021-03-09 5:51 ` Jason Wang
2021-03-17 14:19 ` Elena Afanasova
2021-03-26 6:00 ` Jason Wang
2021-02-21 12:04 ` [RFC v3 3/5] KVM: implement wire protocol Elena Afanasova
2021-02-24 11:02 ` Stefan Hajnoczi
2021-03-09 6:19 ` Jason Wang
2021-03-17 13:08 ` Elena Afanasova
2021-03-26 6:21 ` Jason Wang
2021-03-29 16:17 ` Stefan Hajnoczi
2021-02-21 12:04 ` [RFC v3 4/5] KVM: add ioregionfd context Elena Afanasova
2021-02-24 11:27 ` Stefan Hajnoczi
2021-03-09 7:54 ` Jason Wang
2021-03-09 8:01 ` Paolo Bonzini [this message]
2021-03-10 13:20 ` Elena Afanasova
2021-03-10 14:11 ` Paolo Bonzini
2021-03-10 16:41 ` Elena Afanasova
[not found] ` <6ff79d0b-3b6a-73d3-ffbd-e4af9758735f@redhat.com>
2021-03-17 10:46 ` Elena Afanasova
2021-03-26 6:47 ` Jason Wang
2021-02-21 12:04 ` [RFC v3 5/5] KVM: enforce NR_IOBUS_DEVS limit if kmemcg is disabled Elena Afanasova
2021-02-21 17:06 ` [RFC v3 0/5] Introduce MMIO/PIO dispatch file descriptors (ioregionfd) Paolo Bonzini
2021-02-22 16:40 ` Elena Afanasova
2021-02-24 11:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e7dfb1c-fe13-4e6d-ae65-133116866c2a@redhat.com \
--to=pbonzini@redhat.com \
--cc=cohuck@redhat.com \
--cc=eafanasova@gmail.com \
--cc=elena.ufimtseva@oracle.com \
--cc=jag.raman@oracle.com \
--cc=jasowang@redhat.com \
--cc=john.levon@nutanix.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox