From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Roman Kagan" <rkagan@virtuozzo.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
"Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
"Mohammed Gamal" <mmorsy@redhat.com>,
"Cathy Avery" <cavery@redhat.com>,
linux-kernel@vger.kernel.org, "Jim Mattson" <jmattson@google.com>,
"Liran Alon" <liran.alon@oracle.com>
Subject: Re: [PATCH v2 6/6] KVM: nVMX: optimize prepare_vmcs02{,_full} for Enlightened VMCS case
Date: Wed, 25 Jul 2018 15:31:47 +0200 [thread overview]
Message-ID: <2ed3d00b-bc99-2e2d-3a23-a86de767bfec@redhat.com> (raw)
In-Reply-To: <87effrphu3.fsf@vitty.brq.redhat.com>
On 25/07/2018 15:26, Vitaly Kuznetsov wrote:
> Doing it in nested_vmx_handle_enlightened_vmptrld() is even better: we
> can simplify copy_enlightened_to_vmcs12() too!
Yes, that's true!
> The other place where we set dirty_vmcs12 is the newly introduced
> vmx_set_nested_state() but I think I'm going to add support for eVMCS
> there later and just return something like -ENOTSUPP for now. Too many
> people work on nested simultaneously :-)
Hmm, I think that means you have to put the clean fields in the
vmx_nested struct. Then it's really easy in vmx_set_nested_state to
clear all the clean bits. Touching memory in vmx_set_nested_state is...
*puts on sunglasses* a touchy subject (see comment in kvm/queue's
enter_vmx_non_root_mode).
Thanks,
Paolo
next prev parent reply other threads:[~2018-07-25 13:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 12:30 [PATCH v2 0/6] KVM: nVMX: Enlightened VMCS for Hyper-V on KVM Vitaly Kuznetsov
2018-06-21 12:30 ` [PATCH v2 1/6] KVM: hyperv: define VP assist page helpers Vitaly Kuznetsov
2018-06-21 12:30 ` [PATCH v2 2/6] KVM: VMX: refactor evmcs_sanitize_exec_ctrls() Vitaly Kuznetsov
2018-06-21 12:30 ` [PATCH v2 3/6] KVM: nVMX: add KVM_CAP_HYPERV_ENLIGHTENED_VMCS capability Vitaly Kuznetsov
2018-06-21 12:30 ` [PATCH v2 4/6] KVM: nVMX: add enlightened VMCS state Vitaly Kuznetsov
2018-06-21 12:30 ` [PATCH v2 5/6] KVM: nVMX: implement enlightened VMPTRLD and VMCLEAR Vitaly Kuznetsov
2018-06-21 12:30 ` [PATCH v2 6/6] KVM: nVMX: optimize prepare_vmcs02{,_full} for Enlightened VMCS case Vitaly Kuznetsov
2018-07-24 17:09 ` Paolo Bonzini
2018-07-25 8:37 ` Vitaly Kuznetsov
2018-07-25 12:14 ` Paolo Bonzini
2018-07-25 12:50 ` Vitaly Kuznetsov
2018-07-25 12:55 ` Paolo Bonzini
2018-07-25 13:26 ` Vitaly Kuznetsov
2018-07-25 13:31 ` Paolo Bonzini [this message]
2018-07-25 14:13 ` Vitaly Kuznetsov
2018-07-25 14:39 ` Paolo Bonzini
2018-07-25 15:19 ` Vitaly Kuznetsov
2018-07-23 11:34 ` [PATCH v2 0/6] KVM: nVMX: Enlightened VMCS for Hyper-V on KVM Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ed3d00b-bc99-2e2d-3a23-a86de767bfec@redhat.com \
--to=pbonzini@redhat.com \
--cc=Michael.H.Kelley@microsoft.com \
--cc=cavery@redhat.com \
--cc=haiyangz@microsoft.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mmorsy@redhat.com \
--cc=rkagan@virtuozzo.com \
--cc=rkrcmar@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox