From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
Michael Roth <michael.roth@amd.com>,
kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Michael Roth <michael.roth@amd.com.com>
Subject: Re: [PATCH] KVM: x86: fix CPUID entries returned by KVM_GET_CPUID2 ioctl
Date: Thu, 28 Jan 2021 09:43:05 +0100 [thread overview]
Message-ID: <304bd6db-4c67-a4bd-3b79-74c0474edefa@redhat.com> (raw)
In-Reply-To: <87a6st31c6.fsf@vitty.brq.redhat.com>
On 28/01/21 09:36, Vitaly Kuznetsov wrote:
> This is embarrassing but I have a (possible) excuse: copy_to_user's
> argument is 'void *' so no warning was produced. Surprisingly, no test
> caught the breakage. Thanks for debugging and fixing!
So who writes the test:
- the author of the buggy patch
- the maintainer who failed to spot it
- the poor sod who fixed the issue
?
(Just kidding, it will of course be either me or a fourth person :)).
Paolo
prev parent reply other threads:[~2021-01-28 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 2:44 [PATCH] KVM: x86: fix CPUID entries returned by KVM_GET_CPUID2 ioctl Michael Roth
2021-01-28 7:40 ` Paolo Bonzini
2021-01-28 8:36 ` Vitaly Kuznetsov
2021-01-28 8:43 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304bd6db-4c67-a4bd-3b79-74c0474edefa@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=michael.roth@amd.com.com \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox