From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH 03/15] MIPS: OCTEON: Move CAVIUM_OCTEON_CVMSEG_SIZE to CPU_CAVIUM_OCTEON Date: Tue, 20 May 2014 23:52:06 +0100 Message-ID: <3124276.AVUgu1xWyv@radagast> References: <1400597236-11352-1-git-send-email-andreas.herrmann@caviumnetworks.com> <1400597236-11352-4-git-send-email-andreas.herrmann@caviumnetworks.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1662602.Q1P5RV4oJy"; micalg="pgp-sha1"; protocol="application/pgp-signature" Cc: Andreas Herrmann , David Daney , Ralf Baechle , kvm@vger.kernel.org, David Daney To: linux-mips@linux-mips.org Return-path: Received: from mail-we0-f179.google.com ([74.125.82.179]:44825 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbaETWwT (ORCPT ); Tue, 20 May 2014 18:52:19 -0400 Received: by mail-we0-f179.google.com with SMTP id q59so1198618wes.38 for ; Tue, 20 May 2014 15:52:18 -0700 (PDT) In-Reply-To: <1400597236-11352-4-git-send-email-andreas.herrmann@caviumnetworks.com> Sender: kvm-owner@vger.kernel.org List-ID: --nextPart1662602.Q1P5RV4oJy Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Andreas, On Tuesday 20 May 2014 16:47:04 Andreas Herrmann wrote: > From: David Daney > > CVMSEG is related to the CPU core not the SoC system. So needs to be > configurable there. > > Signed-off-by: David Daney > Signed-off-by: Andreas Herrmann > --- > arch/mips/cavium-octeon/Kconfig | 30 ++++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/arch/mips/cavium-octeon/Kconfig > b/arch/mips/cavium-octeon/Kconfig index 227705d..c5e9975 100644 > --- a/arch/mips/cavium-octeon/Kconfig > +++ b/arch/mips/cavium-octeon/Kconfig > @@ -10,6 +10,17 @@ config CAVIUM_CN63XXP1 > non-CN63XXP1 hardware, so it is recommended to select "n" > unless it is known the workarounds are needed. > > +config CAVIUM_OCTEON_CVMSEG_SIZE > + int "Number of L1 cache lines reserved for CVMSEG memory" > + range 0 54 > + default 1 > + help > + CVMSEG LM is a segment that accesses portions of the dcache as a > + local memory; the larger CVMSEG is, the smaller the cache is. > + This selects the size of CVMSEG LM, which is in cache blocks. The > + legally range is from zero to 54 cache blocks (i.e. CVMSEG LM is > + between zero and 6192 bytes). > + > endif # CPU_CAVIUM_OCTEON > > if CAVIUM_OCTEON_SOC > @@ -23,16 +34,16 @@ config CAVIUM_OCTEON_2ND_KERNEL > with this option to be run at the same time as one built without this > option. > > -config CAVIUM_OCTEON_CVMSEG_SIZE > - int "Number of L1 cache lines reserved for CVMSEG memory" > - range 0 54 > - default 1 > +config CAVIUM_OCTEON_HW_FIX_UNALIGNED > + bool "Enable hardware fixups of unaligned loads and stores" > + default "y" Is adding CAVIUM_OCTEON_HW_FIX_UNALIGNED in this patch intentional? It seems unrelated. Cheers James > help > - CVMSEG LM is a segment that accesses portions of the dcache as a > - local memory; the larger CVMSEG is, the smaller the cache is. > - This selects the size of CVMSEG LM, which is in cache blocks. The > - legally range is from zero to 54 cache blocks (i.e. CVMSEG LM is > - between zero and 6192 bytes). > + Configure the Octeon hardware to automatically fix unaligned loads > + and stores. Normally unaligned accesses are fixed using a kernel > + exception handler. This option enables the hardware automatic fixups, > + which requires only an extra 3 cycles. Disable this option if you > + are running code that relies on address exceptions on unaligned > + accesses. > > config CAVIUM_OCTEON_LOCK_L2 > bool "Lock often used kernel code in the L2" > @@ -86,7 +97,6 @@ config SWIOTLB > select IOMMU_HELPER > select NEED_SG_DMA_LENGTH > > - > config OCTEON_ILM > tristate "Module to measure interrupt latency using Octeon CIU Timer" > help --nextPart1662602.Q1P5RV4oJy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAABAgAGBQJTe9yeAAoJEGwLaZPeOHZ6HHAQAKMtP+jOxvg+2if7hIKnHr2D yfzeBXyz+neSVVeoY1obfOz/+Zy+cSSpQTw6Qz0aJELrBS+k+bXCVCIPQBChoJ3A MdpzbGlqGZlg+g0+OLk4nWzrNtUNyj178b63Rfg/vdF0j9uEPhrWCbJXTAm6gFU8 HHYUKhTKmp0IfFr7dqGN0yT7ucEGrORoPuZ3iilVKQVX4/bQd3goPJIyk9UZXfuK EEgb7gGjlTQpsG7C9RjQPYdVHmlOkBgvfPKNCbWHl9lOH+TdbCUNF9mV2DjGztE5 /JTJmr0NRh3MkLPa+1wuW19bfwgpidOkF5OZB8uaNyXakGCU/r1tu+0/ZOBkkwzm fgHVEtEa8+cUaerSMpYGnm/LQ9CR1sqB5wLX0vXfcjMeha0S6du77Uz1JqM0OTVp oiLfF+xjjYAbSdLRFM99VzRs+f6GvqFIiRyjbLCvlPj7K15SmhV+B8+VXkSYctN8 adxlMxW1/hwU2fgIQm61yUZg9Xn9NaXgOTLlvngVyJ5l8Isz5pyobZPcif1YlzSy jA3wJkOibZPTuJjN/6GojMyh+NxmFIdV4+2XrmkcJ5RZnpuhNjTVew/h7k1NH0z5 v11sW8i/cCxYwqedhBrJIB9hZEc9SEWBlCbDFWNi2LUq8mrkCUcAAMqWTlDwQxJX aaUtIgV9gEdFqeaCCkkX =dWo4 -----END PGP SIGNATURE----- --nextPart1662602.Q1P5RV4oJy--